Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix js errors in customer data when component not initialized #31940

Merged
merged 3 commits into from
Jun 16, 2021
Merged

Fix js errors in customer data when component not initialized #31940

merged 3 commits into from
Jun 16, 2021

Conversation

ihor-sviziev
Copy link
Contributor

@ihor-sviziev ihor-sviziev commented Feb 2, 2021 •
edited
Loading

Description (*)

This PR adds storage initialization with 1 day cookie lifetime (default value before 6c5246a). Once the component initialized - the value for cookie lifetime is getting updated with new settings.

Related Pull Requests

Fixed Issues (if relevant)

  1. Fixes JS error in the customer data #31920

Manual testing scenarios (*)

  1. ...
  2. ...

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Feb 2, 2021

Hi @ihor-sviziev. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@m2-community-project m2-community-project bot added Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround. labels Feb 2, 2021
@ihor-sviziev
Copy link
Contributor Author

@magento run all tests

@ihor-sviziev
Copy link
Contributor Author

@magento run all tests

@ihor-sviziev
Copy link
Contributor Author

@magento run Functional Tests B2B

@ihor-sviziev
Copy link
Contributor Author

@magento run all tests

@ihor-sviziev
Copy link
Contributor Author

@magento run Functional Tests CE

@ihor-sviziev ihor-sviziev mentioned this pull request Feb 10, 2021
Closed
5 tasks
@ihor-sviziev ihor-sviziev mentioned this pull request Feb 22, 2021
Merged
5 tasks
@ihor-sviziev
Copy link
Contributor Author

@magento run Functional Tests CE, Functional Tests EE

1 similar comment
@ihor-sviziev
Copy link
Contributor Author

@magento run Functional Tests CE, Functional Tests EE

@ihor-sviziev
Copy link
Contributor Author

@magento run Functional Tests EE

@ihor-sviziev
Copy link
Contributor Author

@magento run Functional Tests EE

2 similar comments
@ihor-sviziev
Copy link
Contributor Author

@magento run Functional Tests EE

@ihor-sviziev
Copy link
Contributor Author

@magento run Functional Tests EE

@Den4ik Den4ik self-assigned this May 26, 2021
Den4ik
Den4ik approved these changes May 26, 2021
View reviewed changes
Copy link
Contributor

@Den4ik Den4ik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Approved

Changes looks ok and work as expected

@magento-engcom-team
Copy link
Contributor

Hi @Den4ik, thank you for the review.
ENGCOM-9098 has been created to process this Pull Request
✳️ @Den4ik, could you please add one of the following labels to the Pull Request?

Label Description
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests

@Den4ik Den4ik added Award: bug fix Award: category of expertise Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests Risk: low labels May 26, 2021
@dmitriyprime dmitriyprime self-assigned this May 28, 2021
@dmitriyprime
Copy link
Contributor

✔️ QA passed

magento-engcom-team pushed a commit that referenced this pull request Jun 16, 2021
@gabrieldagama
ENGCOM-9098: Fix js errors in customer data when component not initia…
32cb7e9 
…lized #31940
@magento-engcom-team magento-engcom-team merged commit 116c379 into magento:2.4-develop Jun 16, 2021
@m2-assistant
Copy link

m2-assistant bot commented Jun 16, 2021

Hi @ihor-sviziev, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@ihor-sviziev ihor-sviziev deleted the customer-data-fix-js-error branch September 22, 2022 06:40
ihor-sviziev referenced this pull request Sep 22, 2022
@glo05363
cookie expiration date is not updated after Cookie Lifetime is changed
405ee6e
@TuVanDev TuVanDev mentioned this pull request Sep 22, 2022
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Den4ik Den4ik Den4ik approved these changes

Assignees

@Den4ik Den4ik

@dmitriyprime dmitriyprime

Labels
Area: Frontend Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests Award: bug fix Award: category of expertise Component: Customer Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: accept Release Line: 2.4 Risk: low Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

JS error in the customer data
4 participants
@ihor-sviziev @magento-engcom-team @dmitriyprime @Den4ik