Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Template.php #2791

Merged
merged 2 commits into from
Aug 25, 2016
Merged

Update Template.php #2791

merged 2 commits into from
Aug 25, 2016

Conversation

liam-wiltshire
Copy link
Contributor

Updating the comment to reflect that in .phtml files $block is used rather than $this

Updating the comment to reflect that in .phtml files $block is used rather than $this
@liam-wiltshire
Copy link
Contributor Author

Reported in Issue #2785

@davidalger
Copy link
Member

Thank you for the PR! We are currently waiting for the travis builds to work again, which should happen in a few days. Once that is running and the tests are green we can continue to process your contribution. In the mean time, can you please sign the contributor license agreement? You can do this by following the "Details" link next to the "license/cla" check below. Thanks!

@liam-wiltshire
Copy link
Contributor Author

Thanks @davidalger, cla signed!

@mazhalai
Copy link
Contributor

@liam-wiltshire Please merge latest from develop and rerun builds.

@vkorotun vkorotun added Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development bugfix linked and removed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development improvement labels Aug 4, 2016
@vkorotun
Copy link
Contributor

vkorotun commented Aug 8, 2016

Internal ticket: MAGETWO-56557

@vkorotun vkorotun added Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development and removed linked labels Aug 22, 2016
@mmansoor-magento mmansoor-magento merged commit 4521732 into magento:develop Aug 25, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Frontend bugfix Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Progress: accept
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants