Old price excluding TAX shown correct on Product Page

[Krielkip]

With this fix, the price excluding tax of the old price on an product on sale, is not being overwritten with JS. Also checked this for configurable products

Description (*)

I added the the option to add the baseOldPrice, so that in the javascript of the configurable product, all the default actions are the same. No price calculations has been changed.

Fixed Issues (if relevant)

1. Old price excluding TAX is incorrectly replaced by JavaScript #11998: Old price excluding TAX is incorrectly replaced by JavaScript

Manual testing scenarios (*)

[ This needs a template File Edit! ]

1. In Admin, set Stores -> Configuration -> SALES -> Tax -> Price Display Settings -> Display Product Prices In Catalog to "Including and Excluding Tax"
2. Configure tax class and set it for the product
3. Set special price for the product
   4a. In vendor/magento/module-catalog/view/base/templates/product/price/final_price.phtml, set "skip_adjustments" to FALSE for "old-price"
   4b. In vendor/magento/module-configurable-roduct/view/base/templates/product/price/final_price.phtml, set "skip_adjustments" to FALSE for "old-price"
4. Go to a product that has a new special price.

Questions or comments

Please check if all type of products are correct.
I have did some checking, but i can understand that i missed a setup 😸

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds are green)

Has connection with

• Unit Tests incompatible with PHPUnit 8 #27500 : Unit Tests incompatible with PHPUnit 8

[m2-assistant]

Hi @Krielkip. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.4-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

[gabrieldagama]

Hi @Krielkip, thanks for the PR, it looks great! Kudos for updating the Unit Tests, really good work!

Please follow a small comment on the code, also, would you be able to update this PR with 2.4-develop? Thanks!

[gabrieldagama]

Suggested change

	if ($this->getData('price_type') && $this->getData('price_type') !== 'finalPrice') {
	return 'base' . ucfirst($this->getData('price_type'));
	}
	return 'basePrice';
	if ($this->amountRender->getPriceType() === 'finalPrice') {
	return 'basePrice';
	}
	return 'base' . ucfirst($this->amountRender->getPriceType());

I guess it may be easier to understand the === instead of !==. Also, it may be better to use the $this->amountRender->getPriceType() instead of the getData. What do you think?

[engcom-Charlie]

Hi @Krielkip can you please look at #27832 (review)?
Otherwise, we can't proceed with your PR.
Thank you.

[engcom-Charlie]

@magento run all tests

[magento-engcom-team]

Hi @gabrieldagama, thank you for the review.
ENGCOM-8158 has been created to process this Pull Request
✳️ @gabrieldagama, could you please add one of the following labels to the Pull Request?

Label	Description
Auto-Tests: Covered	All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered	Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required	Changes in Pull Request does not require coverage by auto-tests

[engcom-Alfa]

✔️ QA Passed

Manual testing scenario:

1. In Admin, set Stores -> Configuration -> SALES -> Tax -> Price Display Settings -> Display Product Prices In Catalog to "Including and Excluding Tax"
2. Configure tax class and set it for the product
3. Set special price for the product
   4a. In app/code/Magento/Catalog/view/base/templates/product/price/final_price.phtml, set "skip_adjustments" to FALSE for "old-price"
   4b. In app/code/Magento/ConfigurableProduct/view/base/templates/product/price/final_price.phtml, set "skip_adjustments" to FALSE for "old-price"
4. Go to a product that has a new special price.

Before: ✖️ New price and old price excluding TAX are the same

✖️ Simple Product

✖️ Configurable Product

✖️ Bundle Product

After: ✔️ On product detail view page in frontend, old price and new price are displayed with and without TAX

✔️ Simple Product

✔️ Configurable Product

✔️ Bundle Product

✔️ Grouped Product

[m2-assistant]

Hi @Krielkip, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.