-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#27500 Prepare CatalogSearch module Tests for PHPUnit 8 #27818
#27500 Prepare CatalogSearch module Tests for PHPUnit 8 #27818
Conversation
Hi @lbajsarowicz. Thank you for your contribution
For more details, please, review the Magento Contributor Guide documentation. |
app/code/Magento/CatalogSearch/Test/Unit/Model/Adapter/Mysql/Filter/PreprocessorTest.php
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wrong button. Please see my prev. comment
Hi @ihor-sviziev, thank you for the review. |
@ihor-sviziev Done |
Hi @ihor-sviziev, thank you for the review. |
Hi @lbajsarowicz, thank you for your contribution! |
Description (*)
Preparing PHPUnit Tests to run with PHPUnit 8.
PRs for each module is separated to make tests easier to merge.
Related Pull Requests
Fixed Issues (if relevant)
Manual testing scenarios (*)
N/A
Questions or comments
PR #27701 needs to be merged first (otherwise PHPUnit tests fail)
Contribution checklist (*)