Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating link to Adobe CLA in contributing.md #27375

Merged
merged 1 commit into from
Mar 25, 2020
Merged

Updating link to Adobe CLA in contributing.md #27375

merged 1 commit into from
Mar 25, 2020

Conversation

filmaj
Copy link
Contributor

@filmaj filmaj commented Mar 20, 2020

No description provided.

@m2-assistant
Copy link

m2-assistant bot commented Mar 20, 2020

Hi @filmaj. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@ihor-sviziev ihor-sviziev self-assigned this Mar 20, 2020
@ihor-sviziev ihor-sviziev added Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests Cleanup labels Mar 20, 2020
@magento-engcom-team
Copy link
Contributor

Hi @ihor-sviziev, thank you for the review.
ENGCOM-7161 has been created to process this Pull Request

@magento-engcom-team
Copy link
Contributor

@filmaj thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository.

@engcom-Bravo engcom-Bravo self-assigned this Mar 23, 2020
@engcom-Bravo
Copy link
Contributor

✔️ QA Passed
pr7161_link

@engcom-Echo
Copy link
Contributor

@magento run all tests

@engcom-Echo engcom-Echo self-assigned this Mar 23, 2020
@engcom-Echo
Copy link
Contributor

Failed functional tests not related to the changes in this PR

magento-engcom-team pushed a commit that referenced this pull request Mar 25, 2020
@slavvka
ENGCOM-7161: Updating link to Adobe CLA in contributing.md #27375
f6352f5
@magento-engcom-team magento-engcom-team merged commit ee95237 into magento:2.4-develop Mar 25, 2020
@m2-assistant
Copy link

m2-assistant bot commented Mar 25, 2020

Hi @filmaj, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ihor-sviziev ihor-sviziev ihor-sviziev approved these changes

Assignees

@ihor-sviziev ihor-sviziev

@engcom-Bravo engcom-Bravo

@engcom-Echo engcom-Echo

Labels
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests Cleanup Progress: accept Release Line: 2.4
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@filmaj @magento-engcom-team @engcom-Bravo @engcom-Echo @ihor-sviziev