Fix the error that is wrong link title of a downloadable product when enabling "Use Default Value"

[tna274]

Description (*)

Fix the error that is wrong link title of a downloadable product when enabling "Use Default Value"

Related Pull Requests

N/A

Fixed Issues (if relevant)

#27169 - Not able to update value with "use default checkbox" for Downloadable Product

Manual testing scenarios (*)

1. Create a new downloadable product with a link
2. Choose scope at any store view (https://prnt.sc/rgpgs4)
3. In "Downloadable Information" section, uncheck "Use Default Value" box under link title and change link title then saving product
4. At the same product and scope, enable (check) "Use Default Value" box under link title then saving product

Questions or comments

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds are green)

[m2-assistant]

Hi @tna274. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.4-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

[eduard13]

Hi @tna274, thank you for your contribution, could you please review the minor recommendation?
Could you please also check and fix the failing Static Tests?
Thank you.

[tna274]

Hi @eduard13
Could you help me check the functional test. I found some failure test in report but they do not relate to my edited code.
The uncompleted tests relate to cms_block_page and simple product on frontend.

[eduard13]

Indeed, the failing tests aren't related to these changes.

[magento-engcom-team]

Hi @eduard13, thank you for the review.
ENGCOM-7137 has been created to process this Pull Request

[magento-engcom-team]

@tna274 thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository.

[engcom-Alfa]

Hi, @tna274.

During testing, we faced the issue.

Problem: Not able to update the Samples Title by "Use Default Value" checkbox

Manual testing scenario:

1. Create a new downloadable product with a link and sample;
2. Save the product;
   
3. Choose scope at any store view;
   
4. In "Downloadable Information" section, uncheck "Use Default Value" boxes under link title and sample title, and change the values.
5. Save the product;
   
6. Now, check "Use Default Value" boxes under the link and sample titles;
7. Save the product;

Actual Result:
✖️ The default value for the link title was saved but for the sample title was not.

@tna274 Could you take a look?

Thanks!

Pull Request state was updated. Re-review required.

[tna274]

Hi @engcom-Alfa
I've been update PR, please check it again.

[engcom-Alfa]

Hi,@eduard13. Could you review the latest changes? Thanks!

[magento-engcom-team]

Hi @eduard13, thank you for the review.
ENGCOM-7137 has been created to process this Pull Request

[engcom-Alfa]

✔️ QA Passed

[engcom-Kilo]

@magento run Functional Tests B2B, @magento run Functional Tests CE, @magento run Functional Tests EE

[engcom-Echo]

@magento run all tests

[m2-assistant]

Hi @tna274, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.