Fixed issue #27095 - In Floating cart delete pop-up, When user click on out side of OK button than button color is changed

[dipeshrangani]

Related Pull Requests

https://github.com/magento/partners-magento2ee/pull/177

Preconditions (*)

1. Magento2.4-develop

Reference issue (*)

#27095

Steps to reproduce (*)

1. Add to cart product
2. Goto mini cart and click on remove product

Expected result (*)

Actual result (*)

[m2-assistant]

Hi @dipeshrangani. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.4-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

[rogyar]

Hi @dipeshrangani. Thank you for your contribution.

According to the definition of done all changes should be covered by automated tests. I would suggest covering your fix using MFTF test. The test will check that the following selector action-primary action-accept is not present on the page (but action primary action-accept').

Thank you!

[dipeshrangani]

@rogyar I have updated requested changes, please review.

[rogyar]

Hi @dipeshrangani. I believe you don't need additional changes to your fix. As I wrote in my recent comment, you need to create an automated MFTF test that tests the new system behavior. You can check this pull request as an example. It contains the fix itself and the automated test that verifies the fix.

[engcom-Echo]

I will take care of test coverage.

[engcom-Echo]

@magento run all tests

[rogyar]

Could we remove this extra empty line, please?

[engcom-Echo]

@magento run all tests

[rogyar]

Hi @engcom-Echo. Thank you for the coverage.

I believe the failing tests are not related to the current PR (they are fluky tests for Adobe Stock Integration).

[sivaschenko]

Adobe Stock Integration tests are stabilized. Updated branch to rerun the tests

[sivaschenko]

@magento run all tests

[engcom-Echo]

Hi, @rogyar could you please approve it again?

[magento-engcom-team]

Hi @rogyar, thank you for the review.
ENGCOM-7241 has been created to process this Pull Request

[VladimirZaets]

Hi @dipeshrangani. Looks like the issue mentioned in PR is already fixed. Can you please verify it?

Pull Request state was updated. Re-review required.

[engcom-Echo]

Hi, @dipeshrangani, @VladimirZaets. I checked it again, and now this issue can't reproduce - an issue has been fixed.

So, I'm closing this PR now due to an issue is fixed.
Please reopen and update if you wish to continue.
Thank you for your collaboration. 👍

[m2-assistant]

Hi @dipeshrangani, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.