-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue 27009: Fix error fire on catch when create new theme #27026
Issue 27009: Fix error fire on catch when create new theme #27026
Conversation
Hi @vincent-le89. Thank you for your contribution
For more details, please, review the Magento Contributor Guide documentation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you cover that with Unit Test?
- Happy flow (Success)
- Fixed case (Failure)
@lbajsarowicz I think this doesn't need a united test. It is only a simple change. |
@vincent-le89 unfortunately, only members of the maintainers team are allowed to remove progress related labels to the pull request |
Please help me to check this pull request. I think that it's simple to create a unit test. |
Only add a variable to avoid exception in catch
@vincent-le89 unfortunately, only members of the maintainers team are allowed to remove progress related labels to the pull request |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let’s not cover it with test as it will be too hard. I thought it’s public
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Failing functional tests not related to changes from this PR
Hi @ihor-sviziev, thank you for the review. |
Hi @lbajsarowicz, thank you for the review. |
✔️ QA Passed |
Hi @vincent-le89, thank you for your contribution! |
Missing variable outside CATCH causing a double-fault in Renderer.php
Issue: #27009
Description (*)
Declare a variable to avoid firing on an exception
Fixed Issues (if relevant)
Manual testing scenarios (*)
Create a new Theme, with web/css folder empty inside.
Create your default.xml and catalog_product_view.xml
Access to pages and see if there are any exceptions
Questions or comments
Contribution checklist (*)