#26986 REST API Pagination issue

[lbajsarowicz]

Description (*)

1. Covered the issue with API Functional Tests
2. Removed "feature" of overriding currentPage value

Related Pull Requests

• #26986 REST API Pagination issue inventory#2840

Fixed Issues (if relevant)

1. REST API Pagination Does not work as expected #26986
2. REST API page size & current page search criteria options return item(s) past end of data set #8099

Manual testing scenarios (*)

N/A (API Functional Tests cover the change)

Questions or comments

Discussed on Slack and GitHub issue

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds are green)

Support

Solving this issue is supported by Mediotype

[m2-assistant]

Hi @lbajsarowicz. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.4-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

[lbajsarowicz]

I am not going to fix Semantic Version Checker as I replaced mixed return types to proper ones.

[lbajsarowicz]

@magento run all tests

Fixed issue with Test passing by coincidence in MSI repository.

[lbajsarowicz]

The issues for Functional Tests are actually interesting

[lbajsarowicz]

@magento run Functional Tests CE, Functional Tests B2B, Functional Tests EE

It's unclear for me how my change affects these tests. Investigating.

[lbajsarowicz]

Got it! The solution should be easy to provide.
Will work on it in the morning.

[lbajsarowicz]

@magento run all tests

Nailed the issue with "results found" in Admin Panel.
The reason for failure was GROUP BY entity_id used in getSelectCountSql.

By the way - the result of entering 999 page is:

[lbajsarowicz]

@magento run all tests

[lbajsarowicz]

@magento run all tests

What is interesting - the solution already worked for MySQL, but ElasticSearch was unaware of PageSize o.O

[magento-engcom-team]

Hi @lenaorobei, thank you for the review.
ENGCOM-7011 has been created to process this Pull Request

[engcom-Alfa]

✔️ QA Passed

[engcom-Echo]

@magento run all tests

[m2-assistant]

Hi @lbajsarowicz, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.