-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove unused requirejs alias defined #26987
Remove unused requirejs alias defined #26987
Conversation
Hi @mrtuvn. Thank you for your contribution
For more details, please, review the Magento Contributor Guide documentation. |
The error on Functional Tests B2B is not related to the changes introduced. |
Hi any update on this ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm sorry. I've been waiting for tests to pass. Reviewed once again if aliases are not being used - accept.
Hi @lbajsarowicz, thank you for the review.
|
✔️ QA passed |
Hi @mrtuvn, thank you for your contribution! |
Description (*)
Remove unused resources defined
Related Pull Requests
Fixed Issues (if relevant)
Manual testing scenarios (*)
Questions or comments
Seem js files defined before in previous commits but never been used in anywhere in codebase
Contribution checklist (*)