Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused requirejs alias defined #26987

Conversation

mrtuvn
Copy link
Contributor

@mrtuvn mrtuvn commented Feb 23, 2020

Description (*)

Remove unused resources defined

Related Pull Requests

Fixed Issues (if relevant)

  1. Missing JS file (critical-css-loader) in Magento 2.3.4 #26963: Missing JS file (critical-css-loader) in Magento 2.3.4

Manual testing scenarios (*)

  1. ...
  2. ...

Questions or comments

Seem js files defined before in previous commits but never been used in anywhere in codebase

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Feb 23, 2020

Hi @mrtuvn. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@lbajsarowicz
Copy link
Contributor

The error on Functional Tests B2B is not related to the changes introduced.

@lbajsarowicz lbajsarowicz self-requested a review February 25, 2020 03:08
@mrtuvn mrtuvn added the Cleanup label Feb 27, 2020
@orlangur orlangur self-assigned this Feb 28, 2020
@mrtuvn
Copy link
Contributor Author

mrtuvn commented Mar 9, 2020

Hi any update on this ?

Copy link
Contributor

@lbajsarowicz lbajsarowicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm sorry. I've been waiting for tests to pass. Reviewed once again if aliases are not being used - accept.

@magento-engcom-team
Copy link
Contributor

Hi @lbajsarowicz, thank you for the review.
ENGCOM-7065 has been created to process this Pull Request
✳️ @lbajsarowicz, could you please add one of the following labels to the Pull Request?

Label Description
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests

@engcom-Delta engcom-Delta self-assigned this Mar 16, 2020
@engcom-Delta
Copy link
Contributor

✔️ QA passed

@m2-assistant
Copy link

m2-assistant bot commented Mar 19, 2020

Hi @mrtuvn, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@mrtuvn mrtuvn deleted the remove-unused-require-js-alias-defined branch June 7, 2020 10:47
@sdzhepa sdzhepa mentioned this pull request May 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants