Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correctly escape custom product image attributes #26959

Merged
merged 8 commits into from
Mar 15, 2020
Merged

Correctly escape custom product image attributes #26959

merged 8 commits into from
Mar 15, 2020

Conversation

alexander-aleman
Copy link
Contributor

@alexander-aleman alexander-aleman commented Feb 21, 2020 •
edited
Loading

Description (*)

This change tries to solve #25219 by no longer escaping strings of the form attribute-name="attribute value" but direclty rendering and escaping them in the view.

Related Pull Requests

Fixed Issues (if relevant)

  1. Custom attributes of images generated by Block\Product\ImageFactory don't render correctly #25219: Custom attributes of images generated by Block\Product\ImageFactory don't render correctly

Manual testing scenarios (*)

  1. See Custom attributes of images generated by Block\Product\ImageFactory don't render correctly #25219

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Feb 21, 2020

Hi @alexander-aleman. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@alexander-aleman alexander-aleman changed the title Do not escape custom product image attributes Correctly escape custom product image attributes Feb 21, 2020
aleron75
aleron75 previously approved these changes Feb 24, 2020
View reviewed changes
@ghost ghost assigned aleron75 Feb 24, 2020
@aleron75 aleron75 added Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Progress: pending review Award: bug fix and removed Progress: ready for testing labels Feb 24, 2020
@magento-engcom-team
Copy link
Contributor

Hi @aleron75, thank you for the review.
ENGCOM-6962 has been created to process this Pull Request

@engcom-Delta engcom-Delta self-assigned this Feb 26, 2020
@engcom-Delta
Copy link
Contributor

✔️ QA passed

engcom-Delta
engcom-Delta previously requested changes Feb 27, 2020
View reviewed changes
Copy link
Contributor

@engcom-Delta engcom-Delta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @alexander-aleman could you resolve merge conflicts?

@ghost ghost dismissed aleron75’s stale review February 27, 2020 07:50

Pull Request state was updated. Re-review required.

@alexander-aleman
Copy link
Contributor Author

@engcom-Delta it seems some tests are stuck on in progress, could you maybe restart them?

@engcom-Delta
Copy link
Contributor

@magento run all tests

@ghost
Copy link

ghost commented Mar 11, 2020

@alexander-aleman unfortunately, only members of the maintainers team are allowed to remove progress related labels to the pull request

@ghost
Copy link

ghost commented Mar 11, 2020

@alexander-aleman unfortunately, only members of the maintainers team are allowed to add progress related labels to the pull request

@alexander-aleman alexander-aleman dismissed engcom-Delta’s stale review March 11, 2020 10:55

Merge conflicts have been solved

@magento-engcom-team
Copy link
Contributor

Hi @aleron75, thank you for the review.
ENGCOM-6962 has been created to process this Pull Request

@engcom-Delta
Copy link
Contributor

✔️ QA passed

@engcom-Charlie engcom-Charlie self-assigned this Mar 12, 2020
@magento-engcom-team magento-engcom-team mentioned this pull request Mar 15, 2020
Closed
magento-engcom-team pushed a commit that referenced this pull request Mar 15, 2020
@slavvka
ENGCOM-6962: Correctly escape custom product image attributes #26959
16247f6
@magento-engcom-team magento-engcom-team merged commit 7a7adcf into magento:2.4-develop Mar 15, 2020
@m2-assistant
Copy link

m2-assistant bot commented Mar 15, 2020

Hi @alexander-aleman, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@ihor-sviziev ihor-sviziev mentioned this pull request Mar 19, 2020
Closed
4 tasks
@sdzhepa sdzhepa mentioned this pull request May 9, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aleron75 aleron75 aleron75 approved these changes

@jlnarvaez jlnarvaez Awaiting requested review from jlnarvaez

@engcom-Delta engcom-Delta Awaiting requested review from engcom-Delta

Assignees

@aleron75 aleron75

@engcom-Charlie engcom-Charlie

@engcom-Delta engcom-Delta

Labels
Area: Frontend Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Award: bug fix Component: Catalog Partner: XSARUS Progress: accept Release Line: 2.4
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@alexander-aleman @magento-engcom-team @engcom-Delta @aleron75 @engcom-Charlie