Product not exist fix when attempt to get an image

[ilnytskyi]

Description (*)

This PR fixes an issue when async email sending is blocked because the removed product
And this error is shown

main.ERROR: Cron Job sales_send_order_invoice_emails has an error: Call to a member function getData() on null. Statistics: {"sum":0,"count":1,"realmem":0,"emalloc":0,"realmem_start":73400320,"emalloc_start":37177640} [] []
main.CRITICAL: Error when running a cron job {"exception":"[object] (RuntimeException(code: 0): Error when running a cron job at /var/www/html/vendor/magento/module-cron/Observer/ProcessCronQueueObserver.php:327, Error(code: 0): Call to a member function getData() on null at /var/www/html/vendor/magento/module-catalog/Helper/Image.php:502)"} []

Related Pull Requests

Fixed Issues (if relevant)

1. Fixes Error when sending sales mails in async mode if product was removed #26876

Manual testing scenarios (*)

1. See steps form the issue Error when sending sales mails in async mode if product was removed #26876
2. ...

Questions or comments

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds are green)

[m2-assistant]

Hi @ilnytskyi. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.4-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

[magento-engcom-team]

Hi @VladimirZaets, thank you for the review.
ENGCOM-7517 has been created to process this Pull Request
✳️ @VladimirZaets, could you please add one of the following labels to the Pull Request?

Label	Description
Auto-Tests: Covered	All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered	Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required	Changes in Pull Request does not require coverage by auto-tests

[VladimirZaets]

Hi @ilnytskyi. Thanks for collaboration. Due to Magento Definition of Done all code must be covered by tests. Please cover your fix by automated tests or update the existing ones.

[engcom-Echo]

@magento run all tests

[engcom-Echo]

@magento run all tests

[engcom-Alfa]

Hi @ilnytskyi .
Unfortunately, we are not able to reproduce this problem following by steps from the issue .

Precondition:
Have Configurable product with images;

Manual testing scenario:

1. Set up async mails sending ( Go to Admin -> Stores -> Configuration -> Sales -> Sales Emails -> General Settings and set Asynchronous sending to "Enable");
2. Create Order -> Invoice -> Shipment;
3. Send sales mails

Actual Result: ✔️ All 3 messages were received

4. Remove product (along with configurable(parent) product);
5. try to send the invoice again
   

Actual Result: ✔️ the message was successfully received

@ilnytskyi Could you take a look? Maybe we missed something..

Thanks!

Pull Request state was updated. Re-review required.

[ilnytskyi]

@engcom-Alfa
It was actual for 2.3.1 so maybe now somethings is different.
Please confirm that you use cron to sent an email, and the image is used in the email template.

[lenaorobei]

@engcom-Alfa could you please confirm #26877 (comment)

[engcom-Alfa]

Hi @ilnytskyi @lenaorobei .

We checked this PR in more detail again and we were able to reproduce this problem in the following steps:

Precondition:

Since there is no product image variable in the email templates, we have added this programmatically.

Manual testing scenario:

1. Set up async mails sending ( Go to Admin -> Stores -> Configuration -> Sales -> Sales Emails -> General Settings and set Asynchronous sending to Enable);
2. Create a product with an image;
3. Go to Storefront;
4. Add product to Cart and create order;
5. Send sales emails;
6. Run cron;

Actual Result: ✔️ The order confirmation email was received

7. Remove product ;
8. Try to resend sales email (e.g. set column email_sent to Null in relative tables);
9. Run cron;

Actual Result: ✖️ If there are newer sales items planned to send (email_sent is null) emails will not be sent; It leads that sales async mailing stop working

in var/log/cron.log this log appears

@lenaorobei Could you approve it again?

Thanks!

[magento-engcom-team]

Hi @lenaorobei, thank you for the review.
ENGCOM-7517 has been created to process this Pull Request

[engcom-Alfa]

✔️ QA Passed

Precondition:

Since there is no product image variable in the email templates, we have added this programmatically.

Manual testing scenario:

1. Set up async mails sending ( Go to Admin -> Stores -> Configuration -> Sales -> Sales Emails -> General Settings and set Asynchronous sending to Enable);
2. Create a product with an image;
3. Go to Storefront;
4. Add product to Cart and create order;
5. Send sales emails;
6. Run cron;

Actual Result: ✔️ The order confirmation email was received

7. Remove product ;
8. Try to resend sales email (e.g. set column email_sent to Null in relative tables);
9. Run cron;

Before: ✖️ Emails are not sent
✖️ If there are newer sales items planned to send (email_sent is null) emails will not be sent; It leads that sales async mailing stop working

in var/log/cron.log this log appears

After: ✔️ Emails are send

✔️ If there are newer sales items planned to send (email_sent is null) emails will be sent

[m2-assistant]

Hi @ilnytskyi, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.