Unit test for Magento\Downloadable\Model\Sample\DeleteHandler

[karyna-t]

Description (*)

Unit test for Magento\Downloadable\Model\Sample\DeleteHandler

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds are green)

[m2-assistant]

Hi @karyna-tsymbal-atwix. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.4-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

[rogyar]

Just a recommendation for the future to declare constant scope as private. It will reduce the chance of "temptation" to make another dependency on the current test in another test.

[karyna-t]

Thanks for the note, will keep it in mind!

[rogyar]

Another advice is to use return type hinting if we declare strict types in the future. So we have

Suggested change

	public function testExecuteWithDownloadableProduct()
	public function testExecuteWithDownloadableProduct(): void

[magento-engcom-team]

Hi @rogyar, thank you for the review.
ENGCOM-6887 has been created to process this Pull Request

[engcom-Bravo]

✔️ QA Passed

The test is added and passes

[m2-assistant]

Hi @karyna-tsymbal-atwix, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.