Prevent "Overwrite the existing configuration for db-ssl-verify?" question

[flancer64]

This question is occurred every time I run:

$ ./bin/magento setup:config:set

after upgrade to 2.3.4

Also see #26762

We should ask this question only if new value of configuration option is not equal to the old value,.

Resolved issues:

1. resolves [Issue] Prevent "Overwrite the existing configuration for db-ssl-verify?" question #29612: Prevent "Overwrite the existing configuration for db-ssl-verify?" question

[m2-assistant]

Hi @flancer64. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.4-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

[sidolov]

@magento create issue

[ihor-sviziev]

Hi @flancer64,

Thank you for your contribution!
Seems like the listed above issue was already fixed in #26763.
Could you confirm that?

[flancer64]

@ihor-sviziev , I can confirm that the issue is not fixed in #26763.

I've reverted my patch in my local project (based on Magento 2.4.0) and I have the same warning:

$ ./work/bin/magento setup:config:set
Overwrite the existing configuration for db-ssl-verify?[Y/n]

I see code from #26763 in

• ./vendor/magento/magento2-base/setup/src/Magento/Setup/Model/ConfigOptionsList/DriverOptions.php
• ./setup/src/Magento/Setup/Model/ConfigOptionsList/DriverOptions.php

It looks like:

    private function optionExists($options, $driverOptionKey): bool
    {
        return isset($options[$driverOptionKey])
            && ($options[$driverOptionKey] === false || !empty($options[$driverOptionKey]));
    }

I've re-apply my patch and the warning is disappeared.

So, I can confirm that #26763 was not fix the issue listed above.

[ihor-sviziev]

@flancer64 thank you so much for checking it, so I'll review this PR.
do you think it's possible to cover your change with any type of automated test?
Seems to me it will be really hard, for now will put "Auto-Tests: Not Required", but in case if it will be quite simple - would be good to cover it.

[magento-engcom-team]

Hi @ihor-sviziev, thank you for the review.
ENGCOM-8168 has been created to process this Pull Request

[flancer64]

do you think it's possible to cover your change with any type of automated test?

Yes, I think it is possible but I cannot do it. I know nothing about Magento Testing Framework. Sorry.

[engcom-Delta]

✔️ QA passed
Result:
Before:
❌ Overwrite the existing configuration for db-ssl-verify? is shown, when 'driver_options' has no changes in env.php

After:
✔️ Overwrite the existing configuration for db-ssl-verify? message is not shown, when 'driver_options' has no changes in env.php

✔️ Overwrite the existing configuration for db-ssl-verify? message is shown, when 'driver_options' has new value in env.php

[sidolov]

@flancer64 looks like something went wrong with the source branch, it's removed now. I'm closing the PR since we cannot proceed without the source code. Feel free to reopen it in case you want to continue. Thank you for your contribution!

[m2-assistant]

Hi @flancer64, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

[ihor-sviziev]

@flancer64 could you create new PR with the same changes?

[flancer64]

I've removed source branch because I've found another bug in Magento (#30052). I don't know how can I create two different PRs from one fork :(

[flancer64]

I found I can use a branch in my fork.

[flancer64]

@sidolov , done.

I'm sorry, @ihor-sviziev , of cause.