Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Marginal space validation #26768

Conversation

ajithkumar-maragathavel
Copy link
Contributor

Description (*)

No marginal space validation added for identifier field in cms block grid in-line edit.
Magento admin path to CMS Block admin grid :
Content -> Elements -> Blocks

This validation allows us to prevent users from entering leading and trailing spaces in Identifier field using in-line edit in the Grid.

Related Pull Requests

#26261

Closing the above PR, because I accidentally deleted my forked repository and messed up the branch with unwanted commits.

Manual testing scenarios (*)

  1. Enter text with leading and trailing spaces in the Identifier field, and it will display an error message.
  2. Enter text without leading and trailing spaces in the Identifier field and it won't display an error message.

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Feb 8, 2020

Hi @ajithkumar-maragathavel. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@ajithkumar-maragathavel
Copy link
Contributor Author

@rogyar I have made all the changes that you requested in the below PR. Please review it.
#26261
Closing the above PR, since I messed up the branch.

Thanks.

@rogyar rogyar self-assigned this Feb 8, 2020
@rogyar rogyar added the Auto-Tests: Covered All changes in Pull Request is covered by auto-tests label Feb 8, 2020
@ghost
Copy link

ghost commented Feb 9, 2020

@ajithkumar-maragathavel unfortunately, only members of the maintainers team are allowed to remove progress related labels to the pull request

@ajithkumar-maragathavel
Copy link
Contributor Author

@rogyar Updated the code as per your suggestion. Please review it.
Thanks.

@rogyar
Copy link
Contributor

rogyar commented Feb 13, 2020

Awesome, thank you!

@magento-engcom-team
Copy link
Contributor

Hi @rogyar, thank you for the review.
ENGCOM-6888 has been created to process this Pull Request

@engcom-Alfa
Copy link
Contributor

✔️ QA Passed

@m2-assistant
Copy link

m2-assistant bot commented Feb 20, 2020

Hi @ajithkumar-maragathavel, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants