-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Marginal space validation #26768
Marginal space validation #26768
Conversation
Hi @ajithkumar-maragathavel. Thank you for your contribution
For more details, please, review the Magento Contributor Guide documentation. |
app/code/Magento/Cms/Test/Mftf/Test/AdminCreateCmsBlockTest.xml
Outdated
Show resolved
Hide resolved
@ajithkumar-maragathavel unfortunately, only members of the maintainers team are allowed to remove progress related labels to the pull request |
@rogyar Updated the code as per your suggestion. Please review it. |
Awesome, thank you! |
Hi @rogyar, thank you for the review. |
✔️ QA Passed |
Hi @ajithkumar-maragathavel, thank you for your contribution! |
Description (*)
No marginal space validation added for identifier field in cms block grid in-line edit.
Magento admin path to CMS Block admin grid :
Content -> Elements -> Blocks
This validation allows us to prevent users from entering leading and trailing spaces in Identifier field using in-line edit in the Grid.
Related Pull Requests
#26261
Closing the above PR, because I accidentally deleted my forked repository and messed up the branch with unwanted commits.
Manual testing scenarios (*)
Contribution checklist (*)