Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #17933 - Bank Transfer Payment Instructions switch back to default #26765

Merged
merged 1 commit into from
Feb 28, 2020
Merged

Fix #17933 - Bank Transfer Payment Instructions switch back to default #26765

merged 1 commit into from
Feb 28, 2020

Conversation

Bartlomiejsz
Copy link
Contributor

@Bartlomiejsz Bartlomiejsz commented Feb 7, 2020 •
edited
Loading

Description (*)

This is fix for #17933
The issue was caused because observer modified here did override additional_information column in sales_order_payment table with data for incorrect store view.
Also, exactly the same issue occurred for Cash On Delivery and very similar, just for other fields (payable_to and mailing_address), for Check Money Order - both also are resolved with this fix.

Related Pull Requests

Fixed Issues (if relevant)

  1. Bank Transer Payment Instuctions switch back to default #17933: Bank Transer Payment Instuctions switch back to default

Manual testing scenarios (*)

Please check fixed issue for testing scenario

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Feb 7, 2020

Hi @Bartlomiejsz. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@Bartlomiejsz Bartlomiejsz requested a review from YevSent February 7, 2020 22:32
@Bartlomiejsz Bartlomiejsz force-pushed the feature/fix_17933_bank_transfer_instructions_default branch 2 times, most recently from 5d097bf to 8153cc6 Compare February 7, 2020 23:08
aleron75
aleron75 reviewed Feb 20, 2020
View reviewed changes
app/code/Magento/OfflinePayments/Observer/BeforeOrderPaymentSaveObserver.php Outdated
if (!empty($methodInstance->getPayableTo())) {
$payment->setAdditionalInformation('payable_to', $methodInstance->getPayableTo());
$storeId = $payment->getOrder()->getStoreId();
if (!empty($payableTo = $methodInstance->getConfigData('payable_to', $storeId))) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also used to implement assignments within comparisons but one day someone pointed me out that it can be a bit misleading: is the = a real assignment or a bug, that is, a missing==? Reading the code without too much attention (it happens) it may seem a bug, someone could be tempted to correct it causing indeed a bug :)

At that point, I stopped using it and switched back to assigning the variable and doing the comparison in two different statements.

Would you consider doing that change, thus joining my group of old, wise, and defensive programmers like me? :-)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aleron75 I'm not sure if I will get used to do it, but I can definitely try, changed it :)

@aleron75 aleron75 self-assigned this Feb 20, 2020
@aleron75 aleron75 added the Auto-Tests: Covered All changes in Pull Request is covered by auto-tests label Feb 20, 2020
@Bartlomiejsz Bartlomiejsz force-pushed the feature/fix_17933_bank_transfer_instructions_default branch from 8153cc6 to b4dddf1 Compare February 20, 2020 08:50
@Bartlomiejsz Bartlomiejsz force-pushed the feature/fix_17933_bank_transfer_instructions_default branch 2 times, most recently from 6872751 to 4543082 Compare February 20, 2020 13:53
@Bartlomiejsz Bartlomiejsz force-pushed the feature/fix_17933_bank_transfer_instructions_default branch from 4543082 to 7c4be6a Compare February 20, 2020 14:53
@Bartlomiejsz Bartlomiejsz changed the title Fix #17933 - Bank Transer Payment Instuctions switch back to default Fix #17933 - Bank Transfer Payment Instructions switch back to default Feb 20, 2020
@Bartlomiejsz
Copy link
Contributor Author

@aleron75 I rebased changes on develop since those files were also modified there, ready for review again 😉

@magento-engcom-team
Copy link
Contributor

Hi @aleron75, thank you for the review.
ENGCOM-6953 has been created to process this Pull Request

@engcom-Delta engcom-Delta self-assigned this Feb 21, 2020
@engcom-Delta
Copy link
Contributor

✔️ QA passed

@engcom-Delta
Copy link
Contributor

HI @aleron75 could you approve this PR once again to move it into Ready for Testing status?

@ghost ghost removed the Progress: review label Feb 27, 2020
@magento-engcom-team
Copy link
Contributor

Hi @aleron75, thank you for the review.
ENGCOM-6953 has been created to process this Pull Request

@engcom-Charlie engcom-Charlie self-assigned this Feb 27, 2020
@Bartlomiejsz Bartlomiejsz linked an issue Feb 27, 2020 that may be closed by this pull request
Bank Transer Payment Instuctions switch back to default #17933
Closed
@magento-engcom-team magento-engcom-team mentioned this pull request Feb 28, 2020
Closed
magento-engcom-team pushed a commit that referenced this pull request Feb 28, 2020
@slavvka
ENGCOM-6953: Fix #17933 - Bank Transfer Payment Instructions switch b…
5eb2a6a 
…ack to default #26765
@magento-engcom-team magento-engcom-team merged commit 37ed912 into magento:2.4-develop Feb 28, 2020
@m2-assistant
Copy link

m2-assistant bot commented Feb 28, 2020

Hi @Bartlomiejsz, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@Bartlomiejsz Bartlomiejsz deleted the feature/fix_17933_bank_transfer_instructions_default branch June 23, 2020 20:41
@sdzhepa sdzhepa mentioned this pull request May 9, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aleron75 aleron75 aleron75 approved these changes

@YevSent YevSent Awaiting requested review from YevSent

Assignees

@aleron75 aleron75

@engcom-Charlie engcom-Charlie

@engcom-Delta engcom-Delta

Labels
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Award: bug fix Component: OfflinePayments Partner: Fast White Cat partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.4
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bank Transer Payment Instuctions switch back to default
5 participants
@Bartlomiejsz @magento-engcom-team @engcom-Delta @aleron75 @engcom-Charlie