-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[26054-Do not duplicate SEO meta data when duplicating a product] #26659
[26054-Do not duplicate SEO meta data when duplicating a product] #26659
Conversation
Hi @dasharath-wagento. Thank you for your contribution
For more details, please, review the Magento Contributor Guide documentation. |
@magento run all tests |
Hi @dasharath-wagento. Thank you for your contribution. Basically, I agree with the case of the original issue and the solution itself. By the final decision will be on the product owner. |
Hi @rogyar, thank you for the review. |
✔️ QA Passed |
Failed functional test not related to the changes in this PR, test fails on 2.4-develop branch. |
@dasharath-wagento Please resolve the conflicts before we can proceed with your PR |
# Conflicts: # app/code/Magento/Catalog/Model/Product/Copier.php # app/code/Magento/Catalog/Test/Unit/Model/Product/CopierTest.php
Hi @slavvka, @engcom-Charlie. Does this PR still require an additional attention from the contributor/maintainer? Thank you. |
Hi, @slavvka I've resolved conflicts. |
Hi @slavvka, thank you for the review. |
Hi @dasharath-wagento, thank you for your contribution! |
Description (*)
we have add the below field will be empty after Product duplication from catalog Product Option
Meta title
Meta keywords
Meta description
Related Pull Requests
Fixed Issues (if relevant)
Manual testing scenarios (*)
You wold get a below field's values is empty
URL key => It is already generated with unique ID
Meta title => Should be empty
Meta keywords => Should be empty
Meta description => Should be empty
Questions or comments
Contribution checklist (*)