Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[26054-Do not duplicate SEO meta data when duplicating a product] #26659

Merged
merged 6 commits into from
Feb 20, 2020
Merged

[26054-Do not duplicate SEO meta data when duplicating a product] #26659

merged 6 commits into from
Feb 20, 2020

Conversation

dasharath-wagento
Copy link
Contributor

Description (*)

we have add the below field will be empty after Product duplication from catalog Product Option
Meta title
Meta keywords
Meta description

Related Pull Requests

Fixed Issues (if relevant)

  1. Do not duplicate SEO meta data when duplicating a product #26054: Do not duplicate SEO meta data when duplicating a product

Manual testing scenarios (*)

  1. Go to Backed -> Catalog -> Products -> Create a Duplicate From Existing Product & Review
    You wold get a below field's values is empty
    URL key => It is already generated with unique ID
    Meta title => Should be empty
    Meta keywords => Should be empty
    Meta description => Should be empty

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Feb 2, 2020

Hi @dasharath-wagento. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@magento-engcom-team magento-engcom-team added Partner: Wagento Pull Request is created by partner Wagento partners-contribution Pull Request is created by Magento Partner labels Feb 2, 2020
@rogyar rogyar self-assigned this Feb 2, 2020
@rogyar
Copy link
Contributor

rogyar commented Feb 2, 2020

@magento run all tests

@rogyar rogyar added the Auto-Tests: Covered All changes in Pull Request is covered by auto-tests label Feb 2, 2020
@rogyar
Copy link
Contributor

rogyar commented Feb 2, 2020

Hi @dasharath-wagento. Thank you for your contribution. Basically, I agree with the case of the original issue and the solution itself. By the final decision will be on the product owner.

@magento-engcom-team
Copy link
Contributor

Hi @rogyar, thank you for the review.
ENGCOM-6785 has been created to process this Pull Request

@engcom-Alfa
Copy link
Contributor

✔️ QA Passed

@engcom-Golf
Copy link
Contributor

Failed functional test not related to the changes in this PR, test fails on 2.4-develop branch.

@slavvka
Copy link
Member

slavvka commented Feb 8, 2020

@dasharath-wagento Please resolve the conflicts before we can proceed with your PR

@ghost ghost removed the Progress: accept label Feb 8, 2020
# Conflicts:
#	app/code/Magento/Catalog/Model/Product/Copier.php
#	app/code/Magento/Catalog/Test/Unit/Model/Product/CopierTest.php
@engcom-Charlie
Copy link
Contributor

Failed functional test not related to the changes in this PR test fails in 2.4-develop with MSI modules.
image

@rogyar
Copy link
Contributor

rogyar commented Feb 14, 2020

Hi @slavvka, @engcom-Charlie. Does this PR still require an additional attention from the contributor/maintainer?

Thank you.

@engcom-Charlie
Copy link
Contributor

Hi, @slavvka I've resolved conflicts.

@magento-engcom-team
Copy link
Contributor

Hi @slavvka, thank you for the review.
ENGCOM-6785 has been created to process this Pull Request

@m2-assistant
Copy link

m2-assistant bot commented Feb 20, 2020

Hi @dasharath-wagento, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@sdzhepa sdzhepa mentioned this pull request May 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Award: bug fix Component: Catalog Event: mm20in Partner: Wagento Pull Request is created by partner Wagento partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.4
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants