Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend exception message #26511

Merged
merged 9 commits into from
Feb 7, 2020
Merged

Extend exception message #26511

merged 9 commits into from
Feb 7, 2020

Conversation

orozcodiaz
Copy link
Contributor

Update exception messages to provide more detailed information on errors

@orozcodiaz orozcodiaz requested a review from YevSent as a code owner January 23, 2020 16:28
@m2-assistant
Copy link

m2-assistant bot commented Jan 23, 2020

Hi @oroskodias. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@magento-engcom-team magento-engcom-team added Partner: Imagination Media partners-contribution Pull Request is created by Magento Partner labels Jan 23, 2020
@orozcodiaz orozcodiaz removed Partner: Imagination Media partners-contribution Pull Request is created by Magento Partner labels Jan 23, 2020
@edenduong edenduong self-assigned this Jan 23, 2020
@edenduong edenduong added Component: Multishipping Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests labels Jan 23, 2020
edenduong
edenduong requested changes Jan 23, 2020
View reviewed changes
Copy link
Contributor

@edenduong edenduong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please update the .csv file?

@orozcodiaz
Copy link
Contributor Author

Could you please update the .csv file?

done

edenduong
edenduong approved these changes Jan 24, 2020
View reviewed changes
Copy link
Contributor

@edenduong edenduong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution !

@magento-engcom-team
Copy link
Contributor

Hi @edenduong, thank you for the review.
ENGCOM-6678 has been created to process this Pull Request

@engcom-Alfa engcom-Alfa self-assigned this Jan 24, 2020
@ihor-sviziev
Copy link
Contributor

ihor-sviziev commented Jan 24, 2020 •
edited
Loading

I believe this could be tested with unit test.
@oroskodias will you be able to cover your changes with unit test?

@engcom-Alfa engcom-Alfa added Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests and removed Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests labels Jan 24, 2020
@ihor-sviziev ihor-sviziev self-assigned this Jan 28, 2020
@Nazar65 Nazar65 requested a review from ihor-sviziev January 28, 2020 09:44
@magento-engcom-team magento-engcom-team added Partner: Imagination Media partners-contribution Pull Request is created by Magento Partner labels Jan 28, 2020
@magento-engcom-team
Copy link
Contributor

Hi @ihor-sviziev, thank you for the review.
ENGCOM-6678 has been created to process this Pull Request

@magento-engcom-team
Copy link
Contributor

Hi @edenduong, thank you for the review.
ENGCOM-6678 has been created to process this Pull Request

@engcom-Alfa
Copy link
Contributor

✔️ QA Passed

Before:
before

After:
after

@orozcodiaz orozcodiaz removed Partner: Imagination Media partners-contribution Pull Request is created by Magento Partner labels Jan 29, 2020
@magento-engcom-team magento-engcom-team added Partner: Imagination Media partners-contribution Pull Request is created by Magento Partner labels Jan 29, 2020
@orozcodiaz orozcodiaz removed Partner: Imagination Media partners-contribution Pull Request is created by Magento Partner labels Jan 29, 2020
magento-engcom-team pushed a commit that referenced this pull request Feb 7, 2020
@slavvka
ENGCOM-6678: Extend exception message #26511
c53ca65
@magento-engcom-team magento-engcom-team merged commit d1c90b5 into magento:2.4-develop Feb 7, 2020
@m2-assistant
Copy link

m2-assistant bot commented Feb 7, 2020

Hi @oroskodias, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edenduong edenduong edenduong approved these changes

@Nazar65 Nazar65 Nazar65 approved these changes

@ihor-sviziev ihor-sviziev ihor-sviziev approved these changes

@YevSent YevSent Awaiting requested review from YevSent

Assignees

@ihor-sviziev ihor-sviziev

@VladimirZaets VladimirZaets

@edenduong edenduong

@engcom-Alfa engcom-Alfa

@engcom-Echo engcom-Echo

Labels
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Cleanup Component: Multishipping Progress: accept Release Line: 2.4
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@orozcodiaz @magento-engcom-team @ihor-sviziev @engcom-Echo @engcom-Alfa @Nazar65 @edenduong @VladimirZaets