25162 fixed wrong format link #26455

Usik2203 · 2020-01-20T09:20:59Z

Description (*)

This PR fixed #25162 issue

Fixed Issues (if relevant)

Message at Frontend has No HTML format #25162: Message at Frontend has No HTML format

Manual testing scenarios (*)

...
...

Questions or comments

Contribution checklist (*)

Pull request has a meaningful description of its purpose
All commits are accompanied by meaningful commit messages
All new or changed code is covered with unit/integration tests (if applicable)
All automated tests passed successfully (all builds are green)

m2-assistant · 2020-01-20T09:21:02Z

Hi @Usik2203. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

@magento give me test instance - deploy test instance based on PR changes
@magento give me 2.4-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

Usik2203 · 2020-01-20T09:28:13Z

@magento give me test instance

Usik2203 · 2020-01-20T09:45:48Z

Hi @rogyar .
I have closed wrong PR #26328 and created this.
I added MFTF tests as You mentioned before.
I have some trouble with Adobe CLA but I will solve it soon.

Thank You.

magento-engcom-team · 2020-01-21T19:58:30Z

Hi @Usik2203. Thank you for your request. I'm working on Magento instance for you

magento-engcom-team · 2020-01-21T19:58:31Z

Hi @Usik2203. Thank you for your request. I'm working on Magento instance for you

magento-engcom-team · 2020-01-21T20:03:16Z

Hi @Usik2203, here is your new Magento instance.
Admin access: https://pr-26455.instances.magento-community.engineering/admin_e8d7
Login: d1d1f60c Password: d41451532ea1
Instance will be terminated in up to 3 hours.

lbajsarowicz

Only small changes to be applied.

lbajsarowicz · 2020-01-25T00:35:27Z

...sletter/Test/Mftf/ActionGroup/AssertAdminNewsletterConfigFieldGuestNotAllowedActionGroup.xml

+
+<actionGroups xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+              xsi:noNamespaceSchemaLocation="urn:magento:mftf:Test/etc/actionGroupSchema.xsd">
+    <actionGroup name="AssertAdminNewsletterConfigFieldGuestNotAllowedActionGroup">


I'm not sure, but there's no assertion in this Action Group. Maybe there's other name that is better fit?

Hi @lbajsarowicz .
I have applied Your recommendation.

Thank you for your advice.

lbajsarowicz · 2020-01-25T00:36:11Z

app/code/Magento/Newsletter/Test/Mftf/Page/AdminNewsletterConfigPage.xml

+-->
+<pages xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+       xsi:noNamespaceSchemaLocation="urn:magento:mftf:Page/etc/PageObject.xsd">
+    <page name="AdminNewsletterConfigPage" url="admin/system_config/edit/section/newsletter/" area="admin" module="Magento_Newsletter">


You don't need to provide admin/ at the beginning.

Hi @lbajsarowicz.
After changes url="admin/system_config/edit/section/newsletter/" to url="system_config/edit/section/newsletter/"

I am getting such issue. I can't visit config page correctly.

Also I couldn't find examples in core without admin/
Could You Please advise me something about it. If you can.

Thanks.

OK. I'm sorry, revert admin/ then. I'll take a look into it later :-)

lbajsarowicz

Just minor changes to be introduced. Great job! : )

lbajsarowicz · 2020-01-27T12:13:40Z

...Magento/Newsletter/Test/Mftf/Test/VerifyRegistredLinkDisplayedForGuestSubscriptionNoTest.xml

+    <test name="VerifyRegistredLinkDisplayedForGuestSubscriptionNoTest">
+        <before>
+            <!--Log in to Magento as admin.-->
+            <actionGroup ref="LoginAsAdmin" stepKey="loginAsAdmin"/>


Use LoginActionGroup instead, please.

lbajsarowicz · 2020-01-27T12:14:03Z

...Magento/Newsletter/Test/Mftf/Test/VerifyRegistredLinkDisplayedForGuestSubscriptionNoTest.xml

+            <!--Allow Guest Subscription NO-->
+            <actionGroup ref="AdminNewsletterConfigFieldSetGuestNotAllowedActionGroup" stepKey="amOnNewsletterConfigField"/>
+            <!--Log out from Magento admin.-->
+            <actionGroup ref="logout" stepKey="logoutFromAdmin"/>


Use AdminLogoutActionGroup please

magento-engcom-team · 2020-01-27T12:23:39Z

Hi @lbajsarowicz, thank you for the review.
ENGCOM-6691 has been created to process this Pull Request
✳️ @lbajsarowicz, could you please add one of the following labels to the Pull Request?

Label	Description
`Auto-Tests: Covered`	All changes in Pull Request is covered by auto-tests
`Auto-Tests: Not Covered`	Changes in Pull Request requires coverage by auto-tests
`Auto-Tests: Not Required`	Changes in Pull Request does not require coverage by auto-tests

magento-engcom-team · 2020-01-27T12:56:37Z

Hi @lbajsarowicz, thank you for the review.
ENGCOM-6691 has been created to process this Pull Request

engcom-Alfa · 2020-01-27T13:30:15Z

✔️ QA Passed

Before:

After:

engcom-Golf · 2020-01-28T09:34:11Z

@magento run all tests

engcom-Charlie · 2020-01-28T13:24:00Z

@magento run all tests

m2-assistant · 2020-02-07T23:15:14Z

Hi @Usik2203, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Usik2203 added 2 commits January 20, 2020 10:29

25162 fixed wrong format link

690f791

25162 added MFTF tests

141ca96

Usik2203 requested review from buskamuza and melnikovi as code owners January 20, 2020 09:20

fixed code style issue

f060ee7

Usik2203 added the Partner: Atwix Pull Request is created by partner Atwix label Jan 20, 2020

magento-engcom-team added the partners-contribution Pull Request is created by Magento Partner label Jan 21, 2020

Refactored MFTF test

45cd0fa

lbajsarowicz suggested changes Jan 25, 2020

View reviewed changes

ghost assigned lbajsarowicz Jan 25, 2020

ghost added the Progress: needs update label Jan 25, 2020

rename ActionGroup

3e2ea3a

lbajsarowicz approved these changes Jan 27, 2020

View reviewed changes

ghost added Progress: ready for testing and removed Progress: needs update labels Jan 27, 2020

magento-engcom-team added Release Line: 2.4 Area: Frontend Component: Newsletter labels Jan 27, 2020

added minor changes

d6316cf

engcom-Alfa self-assigned this Jan 27, 2020

engcom-Alfa added the Auto-Tests: Covered All changes in Pull Request is covered by auto-tests label Jan 27, 2020

ghost added Progress: testing in progress and removed Progress: ready for testing labels Jan 27, 2020

lbajsarowicz approved these changes Jan 27, 2020

View reviewed changes

ghost added Progress: extended testing and removed Progress: testing in progress labels Jan 27, 2020

engcom-Golf self-assigned this Jan 27, 2020

magento#26455: fix mftf

1251f01

engcom-Charlie self-assigned this Jan 28, 2020

ghost added Progress: accept and removed Progress: extended testing labels Jan 29, 2020

magento-engcom-team assigned VladimirZaets Jan 29, 2020

slavvka mentioned this pull request Feb 7, 2020

Message at Frontend has No HTML format #25162

Closed

magento-engcom-team pushed a commit that referenced this pull request Feb 7, 2020

ENGCOM-6691: 25162 fixed wrong format link #26455

0fdec6e

magento-engcom-team merged commit 1251f01 into magento:2.4-develop Feb 7, 2020

sdzhepa mentioned this pull request May 9, 2022

tyutyu sdzhepa/magento2#5

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

25162 fixed wrong format link #26455

25162 fixed wrong format link #26455

Usik2203 commented Jan 20, 2020

m2-assistant bot commented Jan 20, 2020

Usik2203 commented Jan 20, 2020

Usik2203 commented Jan 20, 2020

magento-engcom-team commented Jan 21, 2020

magento-engcom-team commented Jan 21, 2020

magento-engcom-team commented Jan 21, 2020

lbajsarowicz left a comment

lbajsarowicz Jan 25, 2020

Usik2203 Jan 27, 2020

lbajsarowicz Jan 25, 2020

Usik2203 Jan 27, 2020

lbajsarowicz Jan 27, 2020

lbajsarowicz left a comment

lbajsarowicz Jan 27, 2020

lbajsarowicz Jan 27, 2020

magento-engcom-team commented Jan 27, 2020

magento-engcom-team commented Jan 27, 2020

engcom-Alfa commented Jan 27, 2020 •

edited

Loading

engcom-Golf commented Jan 28, 2020

engcom-Charlie commented Jan 28, 2020

m2-assistant bot commented Feb 7, 2020

25162 fixed wrong format link #26455

25162 fixed wrong format link #26455

Conversation

Usik2203 commented Jan 20, 2020

Description (*)

Fixed Issues (if relevant)

Manual testing scenarios (*)

Questions or comments

Contribution checklist (*)

m2-assistant bot commented Jan 20, 2020

Usik2203 commented Jan 20, 2020

Usik2203 commented Jan 20, 2020

magento-engcom-team commented Jan 21, 2020

magento-engcom-team commented Jan 21, 2020

magento-engcom-team commented Jan 21, 2020

lbajsarowicz left a comment

Choose a reason for hiding this comment

lbajsarowicz Jan 25, 2020

Choose a reason for hiding this comment

Usik2203 Jan 27, 2020

Choose a reason for hiding this comment

lbajsarowicz Jan 25, 2020

Choose a reason for hiding this comment

Usik2203 Jan 27, 2020

Choose a reason for hiding this comment

lbajsarowicz Jan 27, 2020

Choose a reason for hiding this comment

lbajsarowicz left a comment

Choose a reason for hiding this comment

lbajsarowicz Jan 27, 2020

Choose a reason for hiding this comment

lbajsarowicz Jan 27, 2020

Choose a reason for hiding this comment

magento-engcom-team commented Jan 27, 2020

magento-engcom-team commented Jan 27, 2020

engcom-Alfa commented Jan 27, 2020 • edited Loading

engcom-Golf commented Jan 28, 2020

engcom-Charlie commented Jan 28, 2020

m2-assistant bot commented Feb 7, 2020

engcom-Alfa commented Jan 27, 2020 •

edited

Loading