Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add to Compare link not showing in mobile view under 640px #26365

Merged
merged 1 commit into from
Jan 28, 2020
Merged

Add to Compare link not showing in mobile view under 640px #26365

merged 1 commit into from
Jan 28, 2020

Conversation

tejash-wagento
Copy link
Contributor

@tejash-wagento tejash-wagento commented Jan 13, 2020 •
edited
Loading

Description (*)

On Product detail page Add to Compare link is not showing in mobile view under 640px(@screen__s) resolution

Fixed Issues (if relevant)

  1. Add to Compare link not showing in mobile view under 640px #26364: Add to Compare link not showing in mobile view under 640px

Manual testing scenarios (*)

  1. ...
  2. ...

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Jan 13, 2020

Hi @tejash-wagento. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@magento-engcom-team magento-engcom-team added Partner: Wagento Pull Request is created by partner Wagento partners-contribution Pull Request is created by Magento Partner labels Jan 13, 2020
@rogyar rogyar self-assigned this Jan 13, 2020
@rogyar
Copy link
Contributor

rogyar commented Jan 13, 2020

@magento give me test instance

@magento-engcom-team
Copy link
Contributor

Hi @rogyar. Thank you for your request. I'm working on Magento instance for you

@magento-engcom-team
Copy link
Contributor

Hi @rogyar, here is your new Magento instance.
Admin access: https://pr-26365.instances.magento-community.engineering/admin
Login: admin Password: 123123q

@rogyar rogyar added the Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests label Jan 13, 2020
@magento-engcom-team
Copy link
Contributor

Hi @rogyar, thank you for the review.
ENGCOM-6593 has been created to process this Pull Request

@ghost ghost assigned ptylek Jan 13, 2020
@magento-engcom-team
Copy link
Contributor

Hi @ptylek, thank you for the review.
ENGCOM-6593 has been created to process this Pull Request

@engcom-Alfa engcom-Alfa self-assigned this Jan 13, 2020
@engcom-Alfa
Copy link
Contributor

@magento give me test instance

@magento-engcom-team
Copy link
Contributor

Hi @engcom-Alfa. Thank you for your request. I'm working on Magento instance for you

@magento-engcom-team
Copy link
Contributor

Hi @engcom-Alfa, here is your new Magento instance.
Admin access: https://pr-26365.instances.magento-community.engineering/admin
Login: admin Password: 123123q

@engcom-Alfa
Copy link
Contributor

Hi @tejash-wagento.
Could you fix this issue and for the blank theme?

Actual Result:
after

Thanks!

@ptylek
Copy link
Contributor

ptylek commented Jan 16, 2020

@engcom-Alfa I added fix for blank theme #26424

@ghost ghost assigned krzksz Jan 17, 2020
@ghost ghost removed the Progress: needs update label Jan 17, 2020
@magento-engcom-team
Copy link
Contributor

Hi @krzksz, thank you for the review.
ENGCOM-6593 has been created to process this Pull Request

@engcom-Alfa
Copy link
Contributor

@magento give me test instance

@magento-engcom-team
Copy link
Contributor

Hi @engcom-Alfa. Thank you for your request. I'm working on Magento instance for you

@magento-engcom-team
Copy link
Contributor

Hi @engcom-Alfa, here is your new Magento instance.
Admin access: https://pr-26365.instances.magento-community.engineering/admin_f33d
Login: 81e95436 Password: 4314f8588c1e
Instance will be terminated in up to 3 hours.

@engcom-Alfa
Copy link
Contributor

✔️ QA Passed

@engcom-Golf engcom-Golf self-assigned this Jan 17, 2020
@VladimirZaets VladimirZaets mentioned this pull request Jan 28, 2020
Closed
magento-engcom-team pushed a commit that referenced this pull request Jan 28, 2020
@VladimirZaets
ENGCOM-6593: Add to Compare link not showing in mobile view under 640px
c044439 
#26365
@magento-engcom-team magento-engcom-team merged commit f4f61f7 into magento:2.4-develop Jan 28, 2020
@m2-assistant
Copy link

m2-assistant bot commented Jan 28, 2020

Hi @tejash-wagento, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@sdzhepa sdzhepa mentioned this pull request May 9, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ptylek ptylek ptylek approved these changes

@rogyar rogyar rogyar approved these changes

@krzksz krzksz krzksz approved these changes

Assignees

@krzksz krzksz

@rogyar rogyar

@ptylek ptylek

@engcom-Alfa engcom-Alfa

@engcom-Golf engcom-Golf

Labels
Area: Design/Frontend Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests Partner: Wagento Pull Request is created by partner Wagento partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.4
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@tejash-wagento @rogyar @magento-engcom-team @engcom-Alfa @ptylek @krzksz @engcom-Golf