Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Correct both Menu spacing issue] #26238

Merged
merged 5 commits into from
Jan 17, 2020
Merged

[Correct both Menu spacing issue] #26238

merged 5 commits into from
Jan 17, 2020

Conversation

hitesh-wagento
Copy link
Contributor

@hitesh-wagento hitesh-wagento commented Jan 2, 2020 •
edited
Loading

Description (*)

Fixed both Menu spacing issues in the mobile view.

Fixed Issues (if relevant)

  1. Both Menu spacing should be same #26235: Both Menu spacing should be same

Manual testing scenarios (*)

  1. Go to the mobile view
  2. Click on Humber menu

Expected result

  1. Both Menu spacing should be the same
    expected

Actual result

  1. Both Menu spacing different
    actual

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@m2-assistant
Copy link

m2-assistant bot commented Jan 2, 2020

Hi @hitesh-wagento. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@magento-engcom-team magento-engcom-team added Partner: Wagento Pull Request is created by partner Wagento partners-contribution Pull Request is created by Magento Partner labels Jan 2, 2020
@dmytro-ch dmytro-ch self-assigned this Jan 2, 2020
@hitesh-wagento
Copy link
Contributor Author

@dmytro-ch

Can you please guide me how can I resolve Functional Tests error.

Thanks

@dmytro-ch
Copy link
Contributor

Hi @hitesh-wagento,
the functional test error is not relevant to your changes. Please just merge the latest 2.4-develop and it will solve the problem.
Thank you!

@hitesh-wagento hitesh-wagento changed the title [Correct oth Menu spacing issue] [Correct both Menu spacing issue] Jan 3, 2020
@hitesh-wagento
Copy link
Contributor Author

Hi @dmytro-ch

Thank you for the reply I have merged 2.4-develop in my branch

Thanks

@hitesh-wagento hitesh-wagento requested a review from ptylek January 8, 2020 03:29
ptylek
ptylek reviewed Jan 8, 2020
View reviewed changes
app/design/frontend/Magento/blank/web/css/source/_navigation.less Outdated
@@ -154,7 +154,7 @@
&.greet.welcome {
border-top: 1px solid @color-gray82;
font-weight: @font-weight__bold;
padding: .8rem @indent__base;
padding: .8rem 15px;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use @submenu__padding-left variable.

ptylek
ptylek reviewed Jan 8, 2020
View reviewed changes
app/design/frontend/Magento/blank/web/css/source/_navigation.less Outdated
@@ -168,7 +168,7 @@
.lib-css(text-decoration, @navigation-level0-item__text-decoration);
display: block;
font-weight: @font-weight__bold;
padding: .8rem @indent__base;
padding: .8rem 15px;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use @submenu__padding-left variable.

ptylek
ptylek suggested changes Jan 8, 2020
View reviewed changes
Copy link
Contributor

@ptylek ptylek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes requested.

@submenu__padding-left variable has value of 15px and can be found in lib/web/css/source/lib/variables/_navigation.less

@ghost ghost assigned ptylek Jan 8, 2020
@dmytro-ch dmytro-ch added the Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests label Jan 8, 2020
@hitesh-wagento
Copy link
Contributor Author

Hi @ptylek

I have done changes as per your requirement

Thanks

@ghost
Copy link

ghost commented Jan 10, 2020

@hitesh-wagento unfortunately, only members of the maintainers team are allowed to remove progress related labels to the pull request

ptylek
ptylek suggested changes Jan 10, 2020
View reviewed changes
Copy link
Contributor

@ptylek ptylek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, @submenu__padding-left is equal to 15px therefore this line and another one should appear as:
padding: .8rem @submenu__padding-left;

@hitesh-wagento
Copy link
Contributor Author

Hi @ptylek

Sorry for the mistake I have again changed and push my changes

Thanks

ptylek
ptylek approved these changes Jan 10, 2020
View reviewed changes
Copy link
Contributor

@ptylek ptylek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution!

@magento-engcom-team
Copy link
Contributor

Hi @ptylek, thank you for the review.
ENGCOM-6579 has been created to process this Pull Request

@magento-engcom-team
Copy link
Contributor

Hi @dmytro-ch, thank you for the review.
ENGCOM-6579 has been created to process this Pull Request

@engcom-Delta engcom-Delta self-assigned this Jan 13, 2020
@engcom-Delta
Copy link
Contributor

✔️ QA passed

@engcom-Foxtrot engcom-Foxtrot self-assigned this Jan 13, 2020
@VladimirZaets VladimirZaets mentioned this pull request Jan 17, 2020
Closed
magento-engcom-team pushed a commit that referenced this pull request Jan 17, 2020
@VladimirZaets
ENGCOM-6579: [Correct both Menu spacing issue] #26238
9852b58
@magento-engcom-team magento-engcom-team merged commit ad71c04 into magento:2.4-develop Jan 17, 2020
@m2-assistant
Copy link

m2-assistant bot commented Jan 17, 2020

Hi @hitesh-wagento, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@sdzhepa sdzhepa mentioned this pull request May 9, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ptylek ptylek ptylek approved these changes

@dmytro-ch dmytro-ch dmytro-ch approved these changes

Assignees

@dmytro-ch dmytro-ch

@ptylek ptylek

@engcom-Delta engcom-Delta

@engcom-Foxtrot engcom-Foxtrot

Labels
Area: Design/Frontend Area: Frontend Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests Cleanup Partner: Wagento Pull Request is created by partner Wagento partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.4
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@hitesh-wagento @dmytro-ch @magento-engcom-team @engcom-Delta @ptylek @engcom-Foxtrot