-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Theme] Reverting removed container class #26063
[Theme] Reverting removed container class #26063
Conversation
Hi @eduard13. Thank you for your contribution
For more details, please, review the Magento Contributor Guide documentation. |
@magento give me 2.4-develop instance |
Hi @dmytro-ch. Thank you for your request. I'm working on Magento 2.4-develop instance for you |
Hi @dmytro-ch, here is your Magento instance. |
At first, I was thinking of trying to keep both "form-inline" and "admin__scope-old" CSS classes assigned to this container. However, after performing a brief investigation, the @eduard13, thank you for your input! |
✔️ QA Passed |
Hi @eduard13, thank you for your contribution! |
Description (*)
This PR reverts the following #25309 PR, as it has introduced many other style issues, related to Ui.
Fixed Issues (if relevant)
N/A
Manual testing scenarios (*)
Stores / Product [Attributes] / Add New
Expected view
Questions or comments
Basically the following issue #20379 should be opened, and another fix should be provided.
Related comment: #25309 (comment)
Contribution checklist (*)