Issue with reorder when disabled reorder setting from admin issue25130

[edenduong]

Description (*)

1. Resolve Issue with reorder when disabled reorder setting from admin #25130: Issue with reorder when disabled reorder setting from admin

Fixed Issues (if relevant)

1. Issue with reorder when disabled reorder setting from admin #25130: Issue with reorder when disabled reorder setting from admin

Manual testing scenarios (*)

1. Place order from frontend as a customer or guest
2. Open order view page from frontend
3. Login into admin panel
4. Disable reorder option from admin. Navigate to Store -> Configuration-> Sales -> Reorder -> Allow Order and set this to NO
5. Go to opened order view page and click on reorder.

Expected result (*)

1. Reorder should be disabled and there should be some error message Reorder is not available.

Questions or comments

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds are green)

[m2-assistant]

Hi @edenduong. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.4-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

[edenduong]

@lbajsarowicz: I have changed the source code. Please check it again. Thanks :)

[edenduong]

Could you please take a look? Thanks @lbajsarowicz

[lbajsarowicz]

Thank you for your contribution.

[magento-engcom-team]

Hi @lbajsarowicz, thank you for the review.
ENGCOM-6492 has been created to process this Pull Request
✳️ @lbajsarowicz, could you please add one of the following labels to the Pull Request?

Label	Description
Auto-Tests: Covered	All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered	Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required	Changes in Pull Request does not require coverage by auto-tests

[engcom-Alfa]

@edenduong See my comment

[edenduong]

@edenduong See my comment

Thank you. Please check it again. @lbajsarowicz @engcom-Alfa

[engcom-Alfa]

@lbajsarowicz Could you review the last commit?

Thanks!

[engcom-Alfa]

✔️ QA Passed

[slavvka]

MHI failure (Global state usage defined at current file: Magento\Framework\Registry in Magento/Sales/Test/Unit/Controller/Guest/ReorderTest.php) is approved since it is mock for a dependency in the class

[m2-assistant]

Hi @edenduong, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.