-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed ability to save configuration in field without label #25985
Fixed ability to save configuration in field without label #25985
Conversation
Hi @AndreyChorniy. Thank you for your contribution
For more details, please, review the Magento Contributor Guide documentation. |
Hi @aleron75, thank you for the review.
|
Hello @AndreyChorniy |
I will take care of test coverage |
…o fix-23899-system-xml-validation
Hi @aleron75 all changes covered by unit test could you please review ? |
Hello @AndreyChorniy, can you please check the failing unit test? |
@aleron75 test failed because i changed mock file, will fix them tomorrow's, and static test. |
fb97c83
to
63d43ed
Compare
dd78e3a
to
f30a06a
Compare
@aleron75 all done ✔️ |
Hi @aleron75, thank you for the review. |
✔️ QA passed |
Hi @AndreyChorniy, thank you for your contribution! |
Description (*)
This PR add the ability to save the configuration in the field without a label.
Fixed Issues (if relevant)
Manual testing scenarios (*)
System -> Configuration -> {path_to_your_new_field}
Questions or comments
This fix deletes part of
if
expression. In my opinion, we don't need to disallow save fields without labels.Contribution checklist (*)