Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fixed Radio alignment issue] #25966

Conversation

hitesh-wagento
Copy link
Contributor

@hitesh-wagento hitesh-wagento commented Dec 10, 2019

Related Pull Requests

https://github.com/magento/partners-magento2b2b/pull/41

Description (*)

Fixed Radio alignment issue

Fixed Issues (if relevant)

  1. Radio alignment issue #25962: Radio alignment issue

Manual testing scenarios (*)

  1. Add any product in Cart.
  2. Go to Checkout Page.

Expected result

  1. Radio should be aligned.
    expected

Actual result

  1. Radio little bit up.
    actual

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team magento-engcom-team added Partner: Wagento Pull Request is created by partner Wagento partners-contribution Pull Request is created by Magento Partner labels Dec 10, 2019
@m2-assistant
Copy link

m2-assistant bot commented Dec 10, 2019

Hi @hitesh-wagento. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@miguelbalparda
Copy link
Contributor

Hi @hitesh-wagento! Any chance you can check the failing tests? Looks like something you should be able to fix. Thanks!

@miguelbalparda miguelbalparda self-assigned this Dec 10, 2019
@hitesh-wagento
Copy link
Contributor Author

Hi @miguelbalparda,

I can see Static Tests is failed but don't know how to resolve it can you please suggest me.

Thanks

Copy link
Contributor

@krzksz krzksz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @hitesh-wagento, test sais that input[type="radio"] { should use single apostrophes instead.

@ghost ghost assigned krzksz Dec 11, 2019
@hitesh-wagento
Copy link
Contributor Author

Hi @miguelbalparda,

I have changed as per suggestion

Thanks

@ghost
Copy link

ghost commented Dec 13, 2019

@hitesh-wagento unfortunately, only members of the maintainers team are allowed to remove progress related labels to the pull request

@magento-engcom-team
Copy link
Contributor

Hi @krzksz, thank you for the review.
ENGCOM-6480 has been created to process this Pull Request

@engcom-Charlie
Copy link
Contributor

✔️ QA Passed

@engcom-Charlie engcom-Charlie force-pushed the fixed-radio-issue-hitesh branch from 20bb2c5 to b8480b8 Compare January 28, 2020 09:48
@engcom-Golf
Copy link
Contributor

@magento run all tests

@magento magento deleted a comment from Nazar65 Jan 28, 2020
@ghost ghost assigned ptylek Jan 28, 2020
@magento-engcom-team
Copy link
Contributor

Hi @ptylek, thank you for the review.
ENGCOM-6480 has been created to process this Pull Request

@engcom-Bravo
Copy link
Contributor

✔️ QA Passed

@hitesh-wagento
Copy link
Contributor Author

#MM20IN

@lenaorobei lenaorobei added Progress: accept Auto-Tests: Covered All changes in Pull Request is covered by auto-tests and removed Progress: accept Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests labels Feb 3, 2020
@slavvka slavvka mentioned this pull request Feb 8, 2020
@magento-engcom-team magento-engcom-team merged commit b8480b8 into magento:2.4-develop Feb 8, 2020
@m2-assistant
Copy link

m2-assistant bot commented Feb 8, 2020

Hi @hitesh-wagento, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@sdzhepa sdzhepa mentioned this pull request May 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Design/Frontend Area: Frontend Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Event: mm20in Partner: Wagento Pull Request is created by partner Wagento partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.4
Projects
None yet
Development

Successfully merging this pull request may close these issues.