Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add plugin for SalesOrderItemRepository gift message (#19093) #25946

Merged

Conversation

lfolco
Copy link
Contributor

@lfolco lfolco commented Dec 7, 2019

Description (*)

Include orderitem-level gift messages in REST API.

Fixed Issues (if relevant)

  1. API: salesOrderItemRepository does not include gift message #19093: API: salesOrderItemRepository does not include gift message

Manual testing scenarios (*)

  1. Create order with orderitem-level gift message
  2. Call REST API `http://<base_url>/rest/V1/orders/items/<order_id>
  3. Confirm gift message is included in extension attributes

Questions or comments

This was already done in a previous pull request, but never finished.

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@lfolco lfolco requested a review from paliarush as a code owner December 7, 2019 21:02
@m2-assistant
Copy link

m2-assistant bot commented Dec 7, 2019

Hi @lfolco. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@kalpmehta kalpmehta self-assigned this Dec 9, 2019
@kalpmehta
Copy link
Contributor

@magento give me test instance

@magento-engcom-team
Copy link
Contributor

Hi @kalpmehta. Thank you for your request.
Unfortunately, I can only deploy instances for 2.2-develop and 2.3-develop base branches

@kalpmehta
Copy link
Contributor

Hi @lfolco, thanks for your contribution! Can you please check WebAPI failing test?

@lfolco
Copy link
Contributor Author

lfolco commented Jan 4, 2020

Hi @lfolco, thanks for your contribution! Can you please check WebAPI failing test?

All tests are passing now.

@kalpmehta kalpmehta added Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Component: Api Use with concrete module component label E.g. "Component: Api" + "Catalog" labels Jan 5, 2020
@magento-engcom-team magento-engcom-team added Release Line: 2.4 Component: GiftMessage and removed Component: Api Use with concrete module component label E.g. "Component: Api" + "Catalog" labels Jan 5, 2020
@magento-engcom-team
Copy link
Contributor

Hi @kalpmehta, thank you for the review.
ENGCOM-6540 has been created to process this Pull Request

@engcom-Delta
Copy link
Contributor

✔️ QA passed

@m2-assistant
Copy link

m2-assistant bot commented Jan 8, 2020

Hi @lfolco, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@lfolco lfolco deleted the orderitem-giftmessage branch March 14, 2022 21:12
@sdzhepa sdzhepa mentioned this pull request May 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants