Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adobe stock integration Issue-761: Highlight the selected image in the grid #25864

Conversation

serhiyzhovnir
Copy link

This PR adds styles to a selected image in the grid.
Screen Shot 2019-12-01 at 08 59 27
Screen Shot 2019-12-01 at 08 59 13

Fixed Issues (if relevant)

  1. Highlight the selected image in the grid adobe-stock-integration#761: Highlight the selected image in the grid

Manual testing scenarios (*)

  1. Login to admin panel
  2. Open Magento Media Gallery (i.e. go to Cms -> Pages, edit the page and insert image)
  3. Click "Search Adobe Stock" button to open images grid
  4. Click on any image to expand image preview

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Dec 1, 2019

Hi @serhiyzhovnir. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

Copy link
Member

@sivaschenko sivaschenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @serhiyzhovnir ! Can you please cover the added method with a jasmine test?

@ghost ghost assigned sivaschenko Dec 2, 2019
@slavvka
Copy link
Member

slavvka commented Dec 3, 2019

@magento run all tests

@sidolov sidolov changed the base branch from 2.3-develop to 2.4-develop December 5, 2019 17:05
@VladimirZaets
Copy link
Contributor

Hi @serhiyzhovnir. Thanks for collaboration. Due to Magento Definition of Done all code must be covered by tests. Please cover your fix by automated tests.

@sivaschenko sivaschenko added the Auto-Tests: Covered All changes in Pull Request is covered by auto-tests label Dec 19, 2019
@sivaschenko
Copy link
Member

@VladimirZaets this PR is improving the opening image preview functionality that is covered by MFTF tests: https://github.com/magento/adobe-stock-integration/tree/1.1-develop/AdobeStockImageAdminUi/Test/Mftf/Test

@engcom-Delta
Copy link
Contributor

✔️ QA passed

@m2-assistant
Copy link

m2-assistant bot commented Dec 24, 2019

Hi @serhiyzhovnir, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@sdzhepa sdzhepa mentioned this pull request May 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Design/Frontend Area: Frontend Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Component: Ui Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.4
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants