-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adobe stock integration Issue-761: Highlight the selected image in the grid #25864
Adobe stock integration Issue-761: Highlight the selected image in the grid #25864
Conversation
Hi @serhiyzhovnir. Thank you for your contribution
For more details, please, review the Magento Contributor Guide documentation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR @serhiyzhovnir ! Can you please cover the added method with a jasmine test?
@magento run all tests |
Hi @serhiyzhovnir. Thanks for collaboration. Due to Magento Definition of Done all code must be covered by tests. Please cover your fix by automated tests. |
@VladimirZaets this PR is improving the opening image preview functionality that is covered by MFTF tests: https://github.com/magento/adobe-stock-integration/tree/1.1-develop/AdobeStockImageAdminUi/Test/Mftf/Test |
✔️ QA passed |
…d image in the grid #25864
Hi @serhiyzhovnir, thank you for your contribution! |
This PR adds styles to a selected image in the grid.
Fixed Issues (if relevant)
Manual testing scenarios (*)
Contribution checklist (*)