Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MFTF: Extract Action Groups to separate files - magento/module-customer #25828

Merged
merged 15 commits into from
Feb 28, 2020
Merged

MFTF: Extract Action Groups to separate files - magento/module-customer #25828

merged 15 commits into from
Feb 28, 2020

Conversation

lbajsarowicz
Copy link
Contributor

@lbajsarowicz lbajsarowicz commented Nov 28, 2019 •
edited by lenaorobei
Loading

Description (*)

Extract each Action Group to separate file, to follow MFTF Best Practices.

Related Pull Requests

https://github.com/magento/partners-magento2b2b/pull/51

Fixed Issues (if relevant)

  1. [ MFTF ] Mess in ActionGroups: invalid names, multiple nodes. #26331

Questions or comments

Had to extract the changes per-module. The previous try failed, because of conflicts.

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Nov 28, 2019

Hi @lbajsarowicz. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@torhoehn torhoehn self-assigned this Dec 4, 2019
@torhoehn torhoehn self-requested a review December 4, 2019 21:14
@lbajsarowicz
Copy link
Contributor Author

Dear Maintainers, due to your concerns about backward compatibility, I provided the _Deprecated_ActionGroup.xml that provides the deprecated ActionGroups that will be loaded like before, but extra comment was added to notify about depreciation.

Hope that will let you merge that sooner than with 2.4

@torhoehn
Copy link
Contributor

torhoehn commented Dec 5, 2019

@lbajsarowicz Could you please check why the tests are failing in this PR?

@lbajsarowicz
Copy link
Contributor Author

@torhoehn Fixed. When moving Action Groups from multiple files into single file, the duplicated ones were revealed.

@sidolov sidolov changed the base branch from 2.3-develop to 2.4-develop December 5, 2019 17:09
@dmytro-ch dmytro-ch added the Auto-Tests: Covered All changes in Pull Request is covered by auto-tests label Dec 7, 2019
@ghost ghost assigned dmytro-ch Dec 7, 2019
@magento-engcom-team
Copy link
Contributor

Hi @dmytro-ch, thank you for the review.
ENGCOM-6426 has been created to process this Pull Request

@engcom-Alfa engcom-Alfa self-assigned this Dec 9, 2019
@engcom-Alfa
Copy link
Contributor

QA not applicable

@engcom-Golf engcom-Golf self-assigned this Dec 9, 2019
@lbajsarowicz
Copy link
Contributor Author

@magento run all tests

The issue was related to missing change for B2B module

@lbajsarowicz
Copy link
Contributor Author

@magento run all tests

Added missing Copyright to B2B file.

@lenaorobei
Copy link
Contributor

⚠️ Delivery notes: run with pb and pb-ee.

lenaorobei
lenaorobei previously approved these changes Feb 25, 2020
View reviewed changes
@magento-engcom-team
Copy link
Contributor

Hi @lenaorobei, thank you for the review.
ENGCOM-6426 has been created to process this Pull Request

@ghost ghost dismissed lenaorobei’s stale review February 25, 2020 17:22

Pull Request state was updated. Re-review required.

@ghost ghost added the Progress: accept label Feb 25, 2020
@magento-engcom-team
Copy link
Contributor

Hi @lenaorobei, thank you for the review.
ENGCOM-6426 has been created to process this Pull Request

@engcom-Alfa
Copy link
Contributor

QA not applicable

@magento-engcom-team magento-engcom-team mentioned this pull request Feb 28, 2020
Closed
magento-engcom-team pushed a commit that referenced this pull request Feb 28, 2020
@VladimirZaets
ENGCOM-6426: MFTF: Extract Action Groups to separate files - magento/…
46e9eb8 
…module-customer #25828
@magento-engcom-team magento-engcom-team merged commit df30bd2 into magento:2.4-develop Feb 28, 2020
@m2-assistant
Copy link

m2-assistant bot commented Feb 28, 2020

Hi @lbajsarowicz, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@sdzhepa sdzhepa mentioned this pull request May 9, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lenaorobei lenaorobei lenaorobei approved these changes

@dmytro-ch dmytro-ch dmytro-ch approved these changes

@akaplya akaplya Awaiting requested review from akaplya

@paliarush paliarush Awaiting requested review from paliarush

@torhoehn torhoehn Awaiting requested review from torhoehn

Assignees

@torhoehn torhoehn

@dmytro-ch dmytro-ch

@lenaorobei lenaorobei

@engcom-Alfa engcom-Alfa

@engcom-Golf engcom-Golf

Labels
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Award: MFTF test coverage Component: Customer Event: cd-cologne19 Partner: Mediotype Partner: Strix partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.4
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@lbajsarowicz @torhoehn @magento-engcom-team @engcom-Alfa @VladimirZaets @lenaorobei @dmytro-ch @sidolov @engcom-Golf