Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Navigation menu 4th level/category does not appear consistently #25589 #25613

Conversation

fabriciosobral
Copy link

ISSUE LINK #25589

Description (*)

When the submenu was created in the third stage follow, the focus function does not work and submenu doesn't work
Fixed js in UI_MODULES calling lost function

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Nov 15, 2019

Hi @fabriciosobral. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@ghost
Copy link

ghost commented Nov 15, 2019

@fabriciosobral unfortunately, only members of the maintainers team are allowed to assign developers to the pull request

@dmytro-ch dmytro-ch self-assigned this Nov 15, 2019
@rodrigowebjump
Copy link
Member

@magento give me test instance

@magento-engcom-team
Copy link
Contributor

Hi @rodrigowebjump. Thank you for your request. I'm working on Magento instance for you

@rodrigowebjump rodrigowebjump self-assigned this Nov 15, 2019
@magento-engcom-team
Copy link
Contributor

Hi @rodrigowebjump, here is your new Magento instance.
Admin access: https://pr-25613.instances.magento-community.engineering/admin
Login: admin Password: 123123q

@rodrigowebjump
Copy link
Member

@magento give me 2.3-develop instance

@magento-engcom-team
Copy link
Contributor

Hi @rodrigowebjump. Thank you for your request. I'm working on Magento 2.3-develop instance for you

@magento-engcom-team
Copy link
Contributor

Hi @rodrigowebjump, here is your Magento instance.
Admin access: https://i-25613-2-3-develop.instances.magento-community.engineering/admin
Login: admin Password: 123123q
Instance will be terminated in up to 3 hours.

Copy link
Member

@rodrigowebjump rodrigowebjump left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @fabriciosobral

Thanks for your contribution.

@magento-engcom-team
Copy link
Contributor

Hi @rodrigowebjump, thank you for the review.
ENGCOM-6291 has been created to process this Pull Request
✳️ @rodrigowebjump, could you please add one of the following labels to the Pull Request?

Label Description
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests

@engcom-Alfa engcom-Alfa self-assigned this Nov 15, 2019
@dmytro-ch dmytro-ch added Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests Award: bug fix labels Nov 15, 2019
@magento-engcom-team
Copy link
Contributor

Hi @dmytro-ch, thank you for the review.
ENGCOM-6291 has been created to process this Pull Request

@engcom-Alfa
Copy link
Contributor

✔️ QA Passed

Before:
before

After:
after

@m2-assistant
Copy link

m2-assistant bot commented Nov 21, 2019

Hi @fabriciosobral, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@VladimirZaets
Copy link
Contributor

Covered by automated tests in the scope of PR #25704

@VladimirZaets VladimirZaets added Auto-Tests: Covered All changes in Pull Request is covered by auto-tests and removed Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests labels Nov 22, 2019
engcom-Foxtrot pushed a commit to p-bystritsky/magento2 that referenced this pull request Nov 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Lib/Frontend Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Award: bug fix Partner: Webjump partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.3
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants