Prevent page scroll jumping when product gallery loads

[krzksz]

Description (*)

During the investigation of the issue linked below I was able to pinpoint the exact moment of scroll jumping to fotorama's that.resize function which for some reason resets all of its major elements' width and height dimensions. I analysed the code and concluded that since current element height seems to be completely ignored in the whole script and is only set either based on settings or its width and ratio, the code that resets it can be removed. Please not that this can be also true for width but I left it here just to be safe as it doesn't contribute to page jumping.

In addition, min-height was added to prevent initial jump of the gallery when static image is being replaced by fotorama's HTML.

Fixed Issues (if relevant)

1. Mobile product page image jumps #10518: Mobile product page image jumps
2. Product view page scrolls up randomly on mobile device #21717: Product view page scrolls up randomly on mobile device

Manual testing scenarios (*)

1. Open product page with images in the gallery in mobile view.
2. Scroll to the middle of the static image before gallery loads.
3. Page should no longer jump to the top once gallery initializes.

Questions or comments

Please be sure to test this change on multiple browsers and devices including resizing the window through different resolutions as fotorama's configuration changes between breakpoins.

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds are green)

[m2-assistant]

Hi @krzksz. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

[rodrigowebjump]

@magento give me test instance

[magento-engcom-team]

Hi @rodrigowebjump. Thank you for your request. I'm working on Magento instance for you

[magento-engcom-team]

Hi @rodrigowebjump, here is your new Magento instance.
Admin access: https://pr-25385.instances.magento-community.engineering/admin
Login: admin Password: 123123q

[rodrigowebjump]

@magento give me 2.3-develop instance

[magento-engcom-team]

Hi @rodrigowebjump. Thank you for your request. I'm working on Magento 2.3-develop instance for you

[magento-engcom-team]

Hi @rodrigowebjump, here is your Magento instance.
Admin access: https://i-25385-2-3-develop.instances.magento-community.engineering/admin
Login: admin Password: 123123q
Instance will be terminated in up to 3 hours.

[rodrigowebjump]

Hi @krzksz

Thanks for your contribution

[magento-engcom-team]

Hi @rodrigowebjump, thank you for the review.
ENGCOM-6376 has been created to process this Pull Request
✳️ @rodrigowebjump, could you please add one of the following labels to the Pull Request?

Label	Description
Auto-Tests: Covered	All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered	Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required	Changes in Pull Request does not require coverage by auto-tests

[krzksz]

@magento run all tests

[engcom-Delta]

Hi @krzksz Please cover your fix with unit test

[engcom-Golf]

I will take care of test coverage

[engcom-Golf]

@magento run all tests

[magento-engcom-team]

Hi @rodrigowebjump, thank you for the review.
ENGCOM-6376 has been created to process this Pull Request

[engcom-Delta]

✔️ QA passed

[m2-assistant]

Hi @krzksz, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.