Fix 'promotion' region not rendering #25373

[mattijv]

The getRegion(name) method returns a knockoutjs observable array which is a function, so the check used in the template will always resolve to false (as function length property is the number of arguments a function takes, which for the observable array is 0). Therefore the region is never rendered.

Description (*)

The fix in this PR follows the current convention used in Magento and adds the missing parentheses to the if condition.

Fixed Issues (if relevant)

1. The 'promotion' region of the minicart is never rendered #25373: The 'promotion' region of the minicart is never rendered

Manual testing scenarios (*)

See related issue

Questions and comments

This PR is an alternative to #25375. The fix implement in this PR simple and follows the existing code conventions in Magento, but does nothing to prevent a similar mistake from happening in the future.

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds are green)

[m2-assistant]

Hi @mattijv. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

[m2-assistant]

Hi @mattijv, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

[m2-assistant]

Hi @mattijv, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

[mattijv]

Apparently there is some latency to the CLA signing being registered? I'm going to try closing and reopening this PR later.

[m2-assistant]

Hi @mattijv, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

[mattijv]

As far as I can tell, all the failing checks are unrelated to the changes in this PR.

[mattijv]

As #25375 seems to be the preferred fix for the related issue, I'll close this PR as redundant.

[m2-assistant]

Hi @mattijv, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.