Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

M2C-2205 Move LESS styling files #25355

Merged
merged 2 commits into from
Nov 21, 2019
Merged

M2C-2205 Move LESS styling files #25355

merged 2 commits into from
Nov 21, 2019

Conversation

ptylek
Copy link
Contributor

@ptylek ptylek commented Oct 29, 2019 •
edited
Loading

Description (*)

LESS styling for Magento_Contact and Magento_Cms was moved to correct design directory.

Fixed Issues (if relevant)

  1. Magento_Contact module MUST NOT include any design-level LESS styling  #25276: Magento_Contact module MUST NOT include any design-level LESS styling

Manual testing scenarios (*)

  1. Result of find . -type f -name "_module.less"
./design/frontend/Magento/luma/Magento_CustomerBalance/web/css/source/_module.less
./design/frontend/Magento/luma/Magento_AdvancedCheckout/web/css/source/_module.less
./design/frontend/Magento/luma/Magento_LayeredNavigation/web/css/source/_module.less
./design/frontend/Magento/luma/Magento_Theme/web/css/source/_module.less
./design/frontend/Magento/luma/Magento_Reward/web/css/source/_module.less
./design/frontend/Magento/luma/Magento_Review/web/css/source/_module.less
./design/frontend/Magento/luma/Magento_Vault/web/css/source/_module.less
./design/frontend/Magento/luma/Magento_Wishlist/web/css/source/_module.less
./design/frontend/Magento/luma/Magento_Invitation/web/css/source/_module.less
./design/frontend/Magento/luma/Magento_Customer/web/css/source/_module.less
./design/frontend/Magento/luma/Magento_CatalogSearch/web/css/source/_module.less
./design/frontend/Magento/luma/Magento_GiftCard/web/css/source/_module.less
./design/frontend/Magento/luma/Magento_GiftCardAccount/web/css/source/_module.less
./design/frontend/Magento/luma/Magento_Newsletter/web/css/source/_module.less
./design/frontend/Magento/luma/Magento_Rma/web/css/source/_module.less
./design/frontend/Magento/luma/Magento_Sales/web/css/source/_module.less
./design/frontend/Magento/luma/Magento_GiftMessage/web/css/source/_module.less
./design/frontend/Magento/luma/Magento_MultipleWishlist/web/css/source/_module.less
./design/frontend/Magento/luma/Magento_Downloadable/web/css/source/_module.less
./design/frontend/Magento/luma/Magento_GiftWrapping/web/css/source/_module.less
./design/frontend/Magento/luma/Magento_AdvancedSearch/web/css/source/_module.less
./design/frontend/Magento/luma/Magento_Msrp/web/css/source/_module.less
./design/frontend/Magento/luma/Magento_Multishipping/web/css/source/_module.less
./design/frontend/Magento/luma/Magento_GroupedProduct/web/css/source/_module.less
./design/frontend/Magento/luma/Magento_InstantPurchase/web/css/source/_module.less
./design/frontend/Magento/luma/Magento_Checkout/web/css/source/_module.less
./design/frontend/Magento/luma/Magento_Catalog/web/css/source/_module.less
./design/frontend/Magento/luma/Magento_GiftRegistry/web/css/source/_module.less
./design/frontend/Magento/luma/Magento_Bundle/web/css/source/_module.less
./design/frontend/Magento/luma/Magento_SendFriend/web/css/source/_module.less
./design/frontend/Magento/blank/Magento_Swatches/web/css/source/_module.less
./design/frontend/Magento/blank/Magento_AdvancedCheckout/web/css/source/_module.less
./design/frontend/Magento/blank/Magento_LayeredNavigation/web/css/source/_module.less
./design/frontend/Magento/blank/Magento_Theme/web/css/source/_module.less
./design/frontend/Magento/blank/Magento_Reward/web/css/source/_module.less
./design/frontend/Magento/blank/Magento_Braintree/web/css/source/_module.less
./design/frontend/Magento/blank/Magento_Paypal/web/css/source/_module.less
./design/frontend/Magento/blank/Magento_Review/web/css/source/_module.less
./design/frontend/Magento/blank/Magento_CatalogEvent/web/css/source/_module.less
./design/frontend/Magento/blank/Magento_Vault/web/css/source/_module.less
./design/frontend/Magento/blank/Magento_Wishlist/web/css/source/_module.less
./design/frontend/Magento/blank/Magento_Invitation/web/css/source/_module.less
./design/frontend/Magento/blank/Magento_Customer/web/css/source/_module.less
./design/frontend/Magento/blank/Magento_CatalogSearch/web/css/source/_module.less
./design/frontend/Magento/blank/Magento_GiftCard/web/css/source/_module.less
./design/frontend/Magento/blank/Magento_GiftCardAccount/web/css/source/_module.less
./design/frontend/Magento/blank/Magento_Newsletter/web/css/source/_module.less
./design/frontend/Magento/blank/Magento_Rma/web/css/source/_module.less
./design/frontend/Magento/blank/Magento_Sales/web/css/source/_module.less
./design/frontend/Magento/blank/Magento_GiftMessage/web/css/source/_module.less
./design/frontend/Magento/blank/Magento_MultipleWishlist/web/css/source/_module.less
./design/frontend/Magento/blank/Magento_Contact/web/css/source/_module.less
./design/frontend/Magento/blank/Magento_Downloadable/web/css/source/_module.less
./design/frontend/Magento/blank/Magento_GiftWrapping/web/css/source/_module.less
./design/frontend/Magento/blank/Magento_Msrp/web/css/source/_module.less
./design/frontend/Magento/blank/Magento_Multishipping/web/css/source/_module.less
./design/frontend/Magento/blank/Magento_GroupedProduct/web/css/source/_module.less
./design/frontend/Magento/blank/Magento_SalesRule/web/css/source/_module.less
./design/frontend/Magento/blank/Magento_ProductVideo/web/css/source/_module.less
./design/frontend/Magento/blank/Magento_Checkout/web/css/source/_module.less
./design/frontend/Magento/blank/Magento_Catalog/web/css/source/_module.less
./design/frontend/Magento/blank/Magento_GiftRegistry/web/css/source/_module.less
./design/frontend/Magento/blank/Magento_Weee/web/css/source/_module.less
./design/frontend/Magento/blank/Magento_Bundle/web/css/source/_module.less
./design/frontend/Magento/blank/Magento_SendFriend/web/css/source/_module.less
./design/adminhtml/Magento/backend/Magento_Translation/web/css/source/_module.less
./design/adminhtml/Magento/backend/Magento_VersionsCms/web/css/source/_module.less
./design/adminhtml/Magento/backend/Magento_ConfigurableProduct/web/css/source/_module.less
./design/adminhtml/Magento/backend/Magento_CustomerBalance/web/css/source/_module.less
./design/adminhtml/Magento/backend/Magento_AdvancedCheckout/web/css/source/_module.less
./design/adminhtml/Magento/backend/Magento_Reward/web/css/source/_module.less
./design/adminhtml/Magento/backend/Magento_Braintree/web/css/source/_module.less
./design/adminhtml/Magento/backend/Magento_Ui/web/css/source/_module.less
./design/adminhtml/Magento/backend/Magento_Paypal/web/css/source/_module.less
./design/adminhtml/Magento/backend/Magento_Review/web/css/source/_module.less
./design/adminhtml/Magento/backend/Magento_Signifyd/web/css/source/_module.less
./design/adminhtml/Magento/backend/Magento_CatalogPermissions/web/css/source/_module.less
./design/adminhtml/Magento/backend/Magento_Vault/web/css/source/_module.less
./design/adminhtml/Magento/backend/Magento_Customer/web/css/source/_module.less
./design/adminhtml/Magento/backend/Magento_Marketplace/web/css/source/_module.less
./design/adminhtml/Magento/backend/Magento_GiftCard/web/css/source/_module.less
./design/adminhtml/Magento/backend/Magento_Banner/web/css/source/_module.less
./design/adminhtml/Magento/backend/Magento_Integration/web/css/source/_module.less
./design/adminhtml/Magento/backend/Magento_Rma/web/css/source/_module.less
./design/adminhtml/Magento/backend/Magento_CurrencySymbol/web/css/source/_module.less
./design/adminhtml/Magento/backend/Magento_AdminNotification/web/css/source/_module.less
./design/adminhtml/Magento/backend/Magento_Sales/web/css/source/_module.less
./design/adminhtml/Magento/backend/Magento_Contact/web/css/source/_module.less
./design/adminhtml/Magento/backend/Magento_Downloadable/web/css/source/_module.less
./design/adminhtml/Magento/backend/Magento_VisualMerchandiser/web/css/source/_module.less
./design/adminhtml/Magento/backend/Magento_GiftWrapping/web/css/source/_module.less
./design/adminhtml/Magento/backend/Magento_Config/web/css/source/_module.less
./design/adminhtml/Magento/backend/Magento_Staging/web/css/source/_module.less
./design/adminhtml/Magento/backend/Magento_Analytics/web/css/source/_module.less
./design/adminhtml/Magento/backend/Magento_ProductVideo/web/css/source/_module.less
./design/adminhtml/Magento/backend/Magento_Catalog/web/css/source/_module.less
./design/adminhtml/Magento/backend/Magento_Shipping/web/css/source/_module.less
./design/adminhtml/Magento/backend/Magento_AdminAnalytics/web/css/source/_module.less
./design/adminhtml/Magento/backend/Magento_GiftRegistry/web/css/source/_module.less
./design/adminhtml/Magento/backend/Magento_Tax/web/css/source/_module.less
./design/adminhtml/Magento/backend/Magento_ReleaseNotification/web/css/source/_module.less
./design/adminhtml/Magento/backend/Magento_Backend/web/css/source/_module.less

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@ptylek ptylek requested a review from melnikovi as a code owner October 29, 2019 16:18
@m2-assistant
Copy link

m2-assistant bot commented Oct 29, 2019

Hi @ptylek. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@ghost ghost assigned VladimirZaets Oct 29, 2019
@VladimirZaets VladimirZaets added Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests and removed Progress: ready for testing labels Oct 29, 2019
@magento-engcom-team
Copy link
Contributor

Hi @VladimirZaets, thank you for the review.
ENGCOM-6203 has been created to process this Pull Request

VladimirZaets
VladimirZaets requested changes Oct 29, 2019
View reviewed changes
Copy link
Contributor

@VladimirZaets VladimirZaets left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ptylek , please, sign CLA, otherwise, we can't process your pull request

@ptylek
Copy link
Contributor Author

ptylek commented Oct 29, 2019

@VladimirZaets I signed CLA

@ptylek ptylek closed this Oct 29, 2019
@m2-assistant
Copy link

m2-assistant bot commented Oct 29, 2019

Hi @ptylek, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@ptylek ptylek reopened this Oct 29, 2019
@ghost ghost unassigned VladimirZaets Oct 29, 2019
@ptylek ptylek closed this Oct 29, 2019
@m2-assistant
Copy link

m2-assistant bot commented Oct 29, 2019

Hi @ptylek, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@ptylek ptylek reopened this Oct 29, 2019
@VladimirZaets VladimirZaets self-assigned this Oct 29, 2019
@magento-engcom-team magento-engcom-team added Partner: creativestyle partners-contribution Pull Request is created by Magento Partner labels Oct 29, 2019
@magento-engcom-team
Copy link
Contributor

Hi @VladimirZaets, thank you for the review.
ENGCOM-6203 has been created to process this Pull Request

@engcom-Alfa engcom-Alfa self-assigned this Oct 30, 2019
@ptylek
Copy link
Contributor Author

ptylek commented Oct 30, 2019

@engcom-Alfa Good catch, thanks and sorry for inconvenience. I pushed a fix.

@ghost
Copy link

ghost commented Nov 15, 2019

@ptylek unfortunately, only members of the maintainers team are allowed to remove progress related labels to the pull request

@ptylek
Copy link
Contributor Author

ptylek commented Nov 15, 2019

@engcom-Alfa What other updates can be done on this PR in order to move it to Review stage? Thanks in advance.

@engcom-Alfa
Copy link
Contributor

@ptylek Sorry, but we need to get approval from the reviewer.

@engcom-Alfa
Copy link
Contributor

@VladimirZaets Could you review the latest commit?

@ptylek ptylek requested a review from krzksz November 15, 2019 13:48
@magento-engcom-team
Copy link
Contributor

Hi @VladimirZaets, thank you for the review.
ENGCOM-6203 has been created to process this Pull Request

@engcom-Alfa
Copy link
Contributor

✔️ QA Passed

@engcom-Foxtrot engcom-Foxtrot self-assigned this Nov 18, 2019
@VladimirZaets VladimirZaets mentioned this pull request Nov 21, 2019
Closed
magento-engcom-team pushed a commit that referenced this pull request Nov 21, 2019
@VladimirZaets
ENGCOM-6203: M2C-2205 Move LESS styling files #25355
954c449
@magento-engcom-team magento-engcom-team merged commit 2c6ad75 into magento:2.3-develop Nov 21, 2019
@m2-assistant
Copy link

m2-assistant bot commented Nov 21, 2019

Hi @ptylek, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@magento-engcom-team magento-engcom-team added this to the Release: 2.3.5 milestone Nov 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VladimirZaets VladimirZaets VladimirZaets approved these changes

@krzksz krzksz krzksz approved these changes

@melnikovi melnikovi Awaiting requested review from melnikovi

Assignees

@VladimirZaets VladimirZaets

@engcom-Alfa engcom-Alfa

@engcom-Foxtrot engcom-Foxtrot

Labels
Area: Design/Frontend Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests Partner: creativestyle partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.3
Projects
None yet
Milestone
Release: 2.3.5
Development

Successfully merging this pull request may close these issues.
6 participants
@ptylek @magento-engcom-team @engcom-Alfa @krzksz @VladimirZaets @engcom-Foxtrot