13865 safari block cookies breaks javascript scripts #25324

raulvOnestic91 · 2019-10-27T16:07:20Z

Create a popup to warn that the cookies are blocked in the browser.

Description (*)

I fixed this PR creating a js that checks if the navigator has the cookies blocked and warn with a popup that the behavior could be wrong.

Fixed Issues (if relevant)

Safari "Block all cookies" setting breaks JavaScript scripts #13865: Safari "Block all cookies" setting breaks JavaScript scripts

Manual testing scenarios (*)

Open Safari browser and go to Preferences
In Privacy tab enable Block all cookies setting.
Open any Magento shop.

Questions or comments

Contribution checklist (*)

Pull request has a meaningful description of its purpose
All commits are accompanied by meaningful commit messages
[] All new or changed code is covered with unit/integration tests (if applicable)
[] All automated tests passed successfully (all builds are green)

m2-assistant · 2019-10-27T16:07:23Z

Hi @raulvOnestic91. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

@magento give me test instance - deploy test instance based on PR changes
@magento give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

raulvOnestic91 · 2019-10-29T15:29:31Z

hello @DrewML @melnikovi I not able to see what is wrong in the Static Tests, the details page is not charging. Could you tell me what is the error please?

Karlasa · 2019-11-20T08:53:11Z

@magento run all tests

krzksz · 2019-12-01T11:48:51Z

@magento run all tests

app/code/Magento/Theme/view/frontend/web/js/cookie-status.js

krzksz

Please take a look at failing static tests.

magento-engcom-team · 2019-12-02T19:09:45Z

Hi @krzksz, thank you for the review.
ENGCOM-6378 has been created to process this Pull Request
✳️ @krzksz, could you please add one of the following labels to the Pull Request?

Label	Description
`Auto-Tests: Covered`	All changes in Pull Request is covered by auto-tests
`Auto-Tests: Not Covered`	Changes in Pull Request requires coverage by auto-tests
`Auto-Tests: Not Required`	Changes in Pull Request does not require coverage by auto-tests

krzksz · 2019-12-02T19:11:51Z

Hey @magento-engcom-team, I am not able to add a tests label as I am not sure if it is possible to simulate disabled cookies in MFTF.

VladimirZaets · 2019-12-16T16:12:36Z

Hi @raulvOnestic91, @krzksz. In this case, first of all, I think we should create a separate class that will wrap the native navigator class.
It will give a few benefits:

We will control the functionality of Navigator and will have the ability to add/change functionality in just one place.
It will five ability to cover functionality at least by the unit test

krzksz · 2020-02-06T13:48:51Z

dev/tests/js/jasmine/tests/app/code/Magento/Theme/view/frontend/web/js/cookie-status.test.js

+            expect($.fn.cookieStatus).toBeDefined();
+        });
+
+        it('verify that modal does not shows when cookies are supported', function () {


Please change to does not show a modal when cookies are supported.

krzksz · 2020-02-06T13:49:17Z

dev/tests/js/jasmine/tests/app/code/Magento/Theme/view/frontend/web/js/cookie-status.test.js

+            window.navigator = navigator;
+        });
+
+        it('verify initialization cookieStatus widget', function () {


Please change to defines cookieStatus widget.

magento-engcom-team · 2020-02-06T13:55:37Z

Hi @krzksz, thank you for the review.
ENGCOM-6378 has been created to process this Pull Request

engcom-Alfa · 2020-02-06T14:53:32Z

✔️ QA Passed

engcom-Golf · 2020-02-06T19:07:15Z

Failed functional test not related to the changes in this PR, test fails on 2.4-develop branch.

…ascript-scripts

m2-assistant · 2020-02-09T00:23:50Z

Hi @raulvOnestic91, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

raulvOnestic91 added 2 commits October 27, 2019 16:56

magento#13865 create a popup to advice about navigator blocked cookies

b6bd937

magento#13865 remove console log

7e527d8

raulvOnestic91 requested review from DrewML and melnikovi as code owners October 27, 2019 16:07

magento-engcom-team added Area: Frontend Component: Theme Release Line: 2.3 labels Oct 27, 2019

m2-assistant bot added the Squashtoberfest 2019 label Oct 27, 2019

magento#13865 add scapeHtml to popup text

60117ee

krzksz suggested changes Dec 1, 2019

View reviewed changes

app/code/Magento/Theme/view/frontend/web/js/cookie-status.js Outdated Show resolved Hide resolved

app/code/Magento/Theme/view/frontend/web/js/cookie-status.js Outdated Show resolved Hide resolved

app/code/Magento/Theme/view/frontend/web/js/cookie-status.js Outdated Show resolved Hide resolved

ghost assigned krzksz Dec 1, 2019

ghost added the Progress: needs update label Dec 1, 2019

raulvOnestic91 added 2 commits December 2, 2019 08:23

magento#13865 move translate dependecy and remove declaration

0c7ac0c

magento#13865 move options to wiget's options

7316201

krzksz approved these changes Dec 2, 2019

View reviewed changes

ghost added Progress: ready for testing and removed Progress: needs update labels Dec 2, 2019

krzksz suggested changes Dec 2, 2019

View reviewed changes

ghost added Progress: needs update and removed Progress: ready for testing labels Dec 2, 2019

sidolov changed the base branch from 2.3-develop to 2.4-develop December 5, 2019 17:17

sidolov added Release Line: 2.4 and removed Release Line: 2.3 labels Dec 5, 2019

Nazar65 added 2 commits February 6, 2020 15:41

refactor per review commet, add new cases

1692711

remove duplicated check

78e1386

krzksz suggested changes Feb 6, 2020

View reviewed changes

krzksz approved these changes Feb 6, 2020

View reviewed changes

ghost added Progress: ready for testing and removed Progress: needs update labels Feb 6, 2020

rename tests

1b1c8bf

krzksz removed the Squashtoberfest 2019 label Feb 6, 2020

engcom-Alfa self-assigned this Feb 6, 2020

ghost added Progress: testing in progress and removed Progress: ready for testing labels Feb 6, 2020

ghost added Progress: extended testing and removed Progress: testing in progress labels Feb 6, 2020

Nazar65 force-pushed the 13865-safari-block-cookies-breaks-javascript-scripts branch 3 times, most recently from 95b000e to 14112c0 Compare February 6, 2020 15:57

clear test data after each

14112c0

ghost added Progress: accept and removed Progress: extended testing labels Feb 6, 2020

magento-engcom-team added Award: bug fix Award: test coverage labels Feb 6, 2020

Merge branch '2.4-develop' into 13865-safari-block-cookies-breaks-jav…

f7d9193

…ascript-scripts

slavvka mentioned this pull request Feb 9, 2020

Safari "Block all cookies" setting breaks JavaScript scripts #13865

Closed

magento-engcom-team pushed a commit that referenced this pull request Feb 9, 2020

ENGCOM-6378: 13865 safari block cookies breaks javascript scripts #25324

02e6b9b

magento-engcom-team merged commit f7d9193 into magento:2.4-develop Feb 9, 2020

sdzhepa mentioned this pull request May 9, 2022

tyutyu sdzhepa/magento2#5

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

13865 safari block cookies breaks javascript scripts #25324

13865 safari block cookies breaks javascript scripts #25324

raulvOnestic91 commented Oct 27, 2019

m2-assistant bot commented Oct 27, 2019

raulvOnestic91 commented Oct 29, 2019

Karlasa commented Nov 20, 2019

krzksz commented Dec 1, 2019

krzksz left a comment

magento-engcom-team commented Dec 2, 2019

krzksz commented Dec 2, 2019

VladimirZaets commented Dec 16, 2019

krzksz Feb 6, 2020

krzksz Feb 6, 2020

magento-engcom-team commented Feb 6, 2020

engcom-Alfa commented Feb 6, 2020

engcom-Golf commented Feb 6, 2020

m2-assistant bot commented Feb 9, 2020

13865 safari block cookies breaks javascript scripts #25324

13865 safari block cookies breaks javascript scripts #25324

Conversation

raulvOnestic91 commented Oct 27, 2019

Description (*)

Fixed Issues (if relevant)

Manual testing scenarios (*)

Questions or comments

Contribution checklist (*)

m2-assistant bot commented Oct 27, 2019

raulvOnestic91 commented Oct 29, 2019

Karlasa commented Nov 20, 2019

krzksz commented Dec 1, 2019

krzksz left a comment

Choose a reason for hiding this comment

magento-engcom-team commented Dec 2, 2019

krzksz commented Dec 2, 2019

VladimirZaets commented Dec 16, 2019

krzksz Feb 6, 2020

Choose a reason for hiding this comment

krzksz Feb 6, 2020

Choose a reason for hiding this comment

magento-engcom-team commented Feb 6, 2020

engcom-Alfa commented Feb 6, 2020

engcom-Golf commented Feb 6, 2020

m2-assistant bot commented Feb 9, 2020