Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

magento/magento2#22317: PR#22321 fix. #22444

Merged
merged 1 commit into from
May 24, 2019
Merged

magento/magento2#22317: PR#22321 fix. #22444

merged 1 commit into from
May 24, 2019

Conversation

p-bystritsky
Copy link
Contributor

Description (*)

#22321 was merged before it was finished.

Fixed Issues (if relevant)

  1. CodeSniffer should not mark correctly aligned DocBlock elements as code style violation. #22317: CodeSniffer should not mark correctly aligned DocBlock elements as code style violation.

Manual testing scenarios (*)

  1. Edit any Magento 2 class - align method params like shown here.
  2. Create two aligned param comments for one method (one of them should be a substring of relevant param name).
  3. Run static tests.

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@m2-assistant
Copy link

m2-assistant bot commented Apr 21, 2019

Hi @p-bystritsky. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

orlangur
orlangur requested changes Apr 21, 2019
View reviewed changes
dev/tests/static/framework/Magento/Sniffs/Annotation/MethodArgumentsSniff.php Outdated
@@ -124,8 +123,7 @@ private function getMethodArguments(File $phpcsFile, int $openParenthesisPtr, in
private function getMethodParameters(array $paramDefinitions): array
{
$paramName = [];
$paramCount = count($paramDefinitions);
for ($i = 0; $i < $paramCount; $i++) {
foreach (array_keys($paramDefinitions) as $i) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

array_keys is not a good idea. Why cannot use previous implementation? If there are gaps in keys, use foreach and ignore values.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same for all other changed loops.

@ghost ghost assigned orlangur Apr 21, 2019
@orlangur
Copy link
Contributor

@p-bystritsky next time please mark PR as Draft/WiP until it is intended to be merged.

@p-bystritsky
Copy link
Contributor Author

@orlangur updated.

@VasylShvorak VasylShvorak self-assigned this May 21, 2019
@VasylShvorak
Copy link
Contributor

✔️ QA passed

@p-bystritsky p-bystritsky self-assigned this May 22, 2019
@magento-engcom-team magento-engcom-team merged commit 74739b9 into magento:2.3-develop May 24, 2019
magento-engcom-team pushed a commit to okorshenko/magento2 that referenced this pull request May 24, 2019
@sidolov
ENGCOM-5022: magento#22317: PR#22321 fix. magento#22444
a5b089b
@m2-assistant
Copy link

m2-assistant bot commented May 24, 2019

Hi @p-bystritsky, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@magento-engcom-team magento-engcom-team added this to the Release: 2.3.3 milestone May 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@orlangur orlangur orlangur requested changes

Assignees

@orlangur orlangur

@p-bystritsky p-bystritsky

@VasylShvorak VasylShvorak

Labels
Progress: accept Release Line: 2.3
Projects
None yet
Milestone
Release: 2.3.3
Development

Successfully merging this pull request may close these issues.
4 participants
@p-bystritsky @orlangur @VasylShvorak @magento-engcom-team