Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't skip row on import if image not available. #22382

Merged
merged 3 commits into from
Apr 23, 2019
Merged

Don't skip row on import if image not available. #22382

merged 3 commits into from
Apr 23, 2019

Conversation

Nazar65
Copy link
Member

@Nazar65 Nazar65 commented Apr 17, 2019

Description (*)

In this commit d4d34ff was added feature to skip rows on this condition (if empty UrlKey or if urlKey has duplicate, if attribute set is not valid , or if sku is empty) but we don't need to skip row if image was not available.

Fixed Issues (if relevant)

  1. Import product quantity is empty after import #22355: Issue title

Manual testing scenarios (*)

Csv file to upload product, with column base_image and his value This image have to be not exist in folder

  1. Go to admin (System - Import - Products)
  2. Upload csv
  3. Check data
  4. Import

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@m2-assistant
Copy link

m2-assistant bot commented Apr 17, 2019

Hi @Nazar65. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@Nazar65 Nazar65 changed the title Dont't skip row on import if image not available. Don't skip row on import if image not available. Apr 17, 2019
Copy link
Contributor

@orlangur orlangur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Nazar65 cover with test, please.

@ghost ghost assigned orlangur Apr 17, 2019
@Nazar65
Copy link
Member Author

Nazar65 commented Apr 17, 2019

@orlangur ok

@Nazar65
Copy link
Member Author

Nazar65 commented Apr 17, 2019

@orlangur done ✔️

Copy link
Contributor

@orlangur orlangur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Nazar65 perfect! 👍

@magento-engcom-team
Copy link
Contributor

Hi @orlangur, thank you for the review.
ENGCOM-4772 has been created to process this Pull Request

@soleksii
Copy link

✔️ QA Passed

@p-bystritsky
Copy link
Contributor

@Nazar65 please fix failing integration tests.

taskula pushed a commit to Hypernova-Oy/magento2 that referenced this pull request Apr 23, 2019
@magento-engcom-team magento-engcom-team merged commit b6784b5 into magento:2.3-develop Apr 23, 2019
@m2-assistant
Copy link

m2-assistant bot commented Apr 23, 2019

Hi @Nazar65, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@magento-engcom-team magento-engcom-team added this to the Release: 2.3.2 milestone Apr 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants