-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't skip row on import if image not available. #22382
Conversation
Hi @Nazar65. Thank you for your contribution
For more details, please, review the Magento Contributor Assistant documentation |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Nazar65 cover with test, please.
@orlangur ok |
@orlangur done ✔️ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Nazar65 perfect! 👍
Hi @orlangur, thank you for the review. |
✔️ QA Passed |
@Nazar65 please fix failing integration tests. |
Hi @Nazar65, thank you for your contribution! |
Description (*)
In this commit d4d34ff was added feature to skip rows on this condition (if empty UrlKey or if urlKey has duplicate, if attribute set is not valid , or if sku is empty) but we don't need to skip row if image was not available.
Fixed Issues (if relevant)
Manual testing scenarios (*)
Csv file to upload product, with column base_image and his value This image have to be not exist in folder
Contribution checklist (*)