Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix buttonId for credit memo button on admin invoice view #22364

Merged
merged 1 commit into from
Apr 23, 2019
Merged

Fix buttonId for credit memo button on admin invoice view #22364

merged 1 commit into from
Apr 23, 2019

Conversation

kassner
Copy link
Contributor

@kassner kassner commented Apr 16, 2019

Description

Credit Memo button has the wrong buttonId, so it is not possible to customise those buttons in a reliable way.

Manual testing scenarios

  1. Create a plugin that hides/overwrites/changes the capture button in the admin invoice view;
  2. The creditmemo button is affected when it shouldn't.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@m2-assistant
Copy link

m2-assistant bot commented Apr 16, 2019

Hi @kassner. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

orlangur
orlangur requested changes Apr 16, 2019
View reviewed changes
app/code/Magento/Sales/Block/Adminhtml/Order/Invoice/View.php Outdated
@@ -113,8 +113,8 @@ protected function _construct()
$orderPayment->canRefund() && !$this->getInvoice()->getIsUsedForRefund()
) {
$this->buttonList->add(
'capture',
[ // capture?
'creditmemo',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

credit-memo, please. And amend commit.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@orlangur done

@ghost ghost assigned orlangur Apr 16, 2019
@magento-engcom-team
Copy link
Contributor

Hi @orlangur, thank you for the review.
ENGCOM-4773 has been created to process this Pull Request

@VasylShvorak VasylShvorak self-assigned this Apr 19, 2019
@VasylShvorak
Copy link
Contributor

✔️ QA passed

@magento-engcom-team magento-engcom-team merged commit 86c84a4 into magento:2.3-develop Apr 23, 2019
@m2-assistant
Copy link

m2-assistant bot commented Apr 23, 2019

Hi @kassner, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

magento-engcom-team pushed a commit that referenced this pull request Apr 23, 2019
@sivaschenko
ENGCOM-4773: Fix buttonId for credit memo button on admin invoice view …
24dcc13 
…#22364
@magento-engcom-team magento-engcom-team added this to the Release: 2.3.2 milestone Apr 23, 2019
@kassner kassner deleted the patch-19 branch June 1, 2023 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@orlangur orlangur orlangur approved these changes

Assignees

@orlangur orlangur

@VasylShvorak VasylShvorak

Labels
Component: Sales Progress: accept Release Line: 2.3
Projects
None yet
Milestone
Release: 2.3.2
Development

Successfully merging this pull request may close these issues.
4 participants
@kassner @magento-engcom-team @VasylShvorak @orlangur