Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

magento/magento2#21001 - fix unit tests, by passing currency to numbe… #21880

Merged
merged 3 commits into from
Mar 26, 2019
Merged

magento/magento2#21001 - fix unit tests, by passing currency to numbe… #21880

merged 3 commits into from
Mar 26, 2019

Conversation

kdegorski
Copy link
Contributor

@kdegorski kdegorski commented Mar 21, 2019 •
edited
Loading

…r formatter, then it behaves as was expected in test.

Description (*)

The changes are only in unit tests which were'nt testing what they supposed to. Added neccessary parameters to achieve that goal

Fixed Issues (if relevant)

  1. Unit Tests failed #21001 - Unit Tests failed

Manual testing scenarios (*)

  1. Run the unit tests 2.3.0/vendor/magento/framework/Locale/Test/Unit/FormatTest.php

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@kdegorski
magento#21001 - fix unit tests, by passing currency to number formatt…
b96435f 
…er, then it behaves as was expected in test.
@magento-cicd2
Copy link
Contributor

magento-cicd2 commented Mar 21, 2019 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@magento-engcom-team
Copy link
Contributor

Hi @kdegorski. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@kdegorski
magento#21001 - fix unit tests, by passing currency to number formatt…
8d7b964 
…er, then it behaves as was expected in test.
@dmytro-ch dmytro-ch self-requested a review March 22, 2019 07:36
@dmytro-ch dmytro-ch self-assigned this Mar 22, 2019
orlangur
orlangur approved these changes Mar 22, 2019
View reviewed changes
Copy link
Contributor

@orlangur orlangur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch @kdegorski!

@ghost ghost assigned orlangur Mar 22, 2019
@magento-engcom-team
Copy link
Contributor

Hi @orlangur, thank you for the review.
ENGCOM-4554 has been created to process this Pull Request

@soleksii soleksii self-assigned this Mar 22, 2019
@magento-engcom-team
Copy link
Contributor

Hi @dmytro-ch, thank you for the review.
ENGCOM-4554 has been created to process this Pull Request

@soleksii
Copy link

Hi @kdegorski ! I've checked PR and looks like that these changes doesn't solve the problem completely.

Actual result:
screen

ICU version => 63.1

Thanks!

@kdegorski
Copy link
Contributor Author

kdegorski commented Mar 22, 2019 •
edited
Loading

According to thread https://bugs.openjdk.java.net/browse/JDK-8211262 there was a change of de_CH grouping character - so there's not option to make those tests apply to different versions of ICU. (since CLDR v33)
@stoleksiy Should I remove this test case?

@soleksii
Copy link

@kdegorski You do not need to remove test case. We will approve these changes as they are. Thanks!

@soleksii
Copy link

✔️ QA Passed

@orlangur
Copy link
Contributor

@kdegorski @stoleksiy why not make decimalSymbol ICU-version-dependent?

@nmalevanec nmalevanec self-assigned this Mar 22, 2019
orlangur
orlangur approved these changes Mar 22, 2019
View reviewed changes
Copy link
Contributor

@orlangur orlangur left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @kdegorski, looks much more robust now 👍

@magento-engcom-team
Copy link
Contributor

Hi @orlangur, thank you for the review.
ENGCOM-4554 has been created to process this Pull Request

@magento-engcom-team magento-engcom-team mentioned this pull request Mar 26, 2019
Closed
@magento-engcom-team magento-engcom-team merged commit 3825545 into magento:2.3-develop Mar 26, 2019
@ghost
Copy link

ghost commented Mar 26, 2019

Hi @kdegorski, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

magento-engcom-team pushed a commit that referenced this pull request Mar 26, 2019
@sivaschenko
ENGCOM-4554: #21001 - fix unit tests, by passing currency to numbe… #…
72374dc 
…21880
@magento-engcom-team magento-engcom-team added this to the Release: 2.3.2 milestone Mar 26, 2019
@kdegorski kdegorski deleted the 21001 branch March 26, 2019 23:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmytro-ch dmytro-ch dmytro-ch approved these changes

@orlangur orlangur orlangur approved these changes

Assignees

@orlangur orlangur

@nmalevanec nmalevanec

@dmytro-ch dmytro-ch

@soleksii soleksii

Labels
Award: bug fix Component: Locale Event: snowdog-oss Progress: accept Release Line: 2.3
Projects
None yet
Milestone
Release: 2.3.2
Development

Successfully merging this pull request may close these issues.
8 participants
@kdegorski @magento-cicd2 @magento-engcom-team @soleksii @orlangur @dmytro-ch @dmanners @nmalevanec