Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix importFromArray by setting _isCollectionLoaded to true after import #21869

Merged
merged 3 commits into from
Apr 18, 2019
Merged

Fix importFromArray by setting _isCollectionLoaded to true after import #21869

merged 3 commits into from
Apr 18, 2019

Conversation

slackerzz
Copy link
Member

@slackerzz slackerzz commented Mar 21, 2019 •
edited
Loading

Description (*)

Method \Magento\Eav\Model\Entity\Collection\AbstractCollection::importFromArray() returns an unusable collection because its property _isCollectionLoaded is false and every interaction throw an exception as described in #21868.

Fixed Issues (if relevant)

  1. Method importFromArray from \Magento\Eav\Model\Entity\Collection\AbstractCollection doesn't return a working collection #21868: Method importFromArray from \Magento\Eav\Model\Entity\Collection\AbstractCollection doesn't return a working collection

Manual testing scenarios (*)

  1. Refer to Method importFromArray from \Magento\Eav\Model\Entity\Collection\AbstractCollection doesn't return a working collection #21868

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @slackerzz. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@rogyar rogyar self-assigned this Mar 22, 2019
@magento-engcom-team
Copy link
Contributor

Hi @rogyar, thank you for the review.
ENGCOM-4553 has been created to process this Pull Request

@soleksii soleksii self-assigned this Apr 1, 2019
@soleksii
Copy link

soleksii commented Apr 1, 2019

✔️ QA Passed

Before:

after

After:

before

@p-bystritsky p-bystritsky self-assigned this Apr 2, 2019
@p-bystritsky p-bystritsky force-pushed the fix_collection_importFromArray branch from feef697 to 4082a76 Compare April 3, 2019 11:20
@p-bystritsky p-bystritsky force-pushed the fix_collection_importFromArray branch from 4082a76 to 0de4572 Compare April 9, 2019 08:05
@magento-engcom-team magento-engcom-team mentioned this pull request Apr 18, 2019
Closed
@magento-engcom-team magento-engcom-team merged commit 0de4572 into magento:2.3-develop Apr 18, 2019
@m2-assistant
Copy link

m2-assistant bot commented Apr 18, 2019

Hi @slackerzz, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

magento-engcom-team pushed a commit that referenced this pull request Apr 18, 2019
@sivaschenko
ENGCOM-4553: Fix importFromArray by setting _isCollectionLoaded to tr…
4d47daf 
…ue after import #21869
@magento-engcom-team magento-engcom-team added this to the Release: 2.3.2 milestone Apr 18, 2019
@slackerzz slackerzz mentioned this pull request Apr 19, 2019
Merged
4 tasks
@slackerzz slackerzz deleted the fix_collection_importFromArray branch April 19, 2019 07:30
magento-engcom-team added a commit that referenced this pull request Apr 22, 2019
@magento-engcom-team
ENGCOM-4787: Backport - Fix importFromArray by setting _isCollectionL…
d11cc25 
…oaded to true after import #21869 #22422

 - Merge Pull Request #22422 from slackerzz/magento2:back-port-pull-21869
 - Merged commits:
   1. e1f91d1
magento-engcom-team pushed a commit that referenced this pull request Apr 22, 2019
@sidolov
ENGCOM-4787: Backport - Fix importFromArray by setting _isCollectionL…
5a1438f 
…oaded to true after import #21869 #22422
magento-engcom-team added a commit that referenced this pull request Apr 22, 2019
@magento-engcom-team
🔃 [EngCom] Public Pull Requests - 2.2-develop
a1daa45 
Accepted Public Pull Requests:
 - #22422: Backport - Fix importFromArray by setting _isCollectionLoaded to true after import #21869 (by @slackerzz)
 - #22282: [Backport] Fixed "Please specify the admin custom URL" error on app:config:import CLI command (by @davidalger)


Fixed GitHub Issues:
 - #21868: Method importFromArray from \Magento\Eav\Model\Entity\Collection\AbstractCollection doesn't return a working collection (reported by @slackerzz) has been fixed in #22422 by @slackerzz in 2.2-develop branch
   Related commits:
     1. e1f91d1

 - #15090: app:config:import fails with "Please specify the admin custom URL." (reported by @BlitzInternet) has been fixed in #22282 by @davidalger in 2.2-develop branch
   Related commits:
     1. e12eeaa
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rogyar rogyar rogyar approved these changes

Assignees

@rogyar rogyar

@p-bystritsky p-bystritsky

@soleksii soleksii

Labels
Award: bug fix Component: Eav Partner: MageSpecialist partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.3
Projects
None yet
Milestone
Release: 2.3.2
Development

Successfully merging this pull request may close these issues.
5 participants
@slackerzz @magento-engcom-team @soleksii @rogyar @p-bystritsky