Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for issue #21510: Can't access backend indexers page after creating a custom index #21575

Merged
merged 4 commits into from
Mar 20, 2019

Conversation

ccasciotti
Copy link
Contributor

@ccasciotti ccasciotti commented Mar 5, 2019

Description (*)

This PR is a fix for issue #21510.

Fixed Issues (if relevant)

  1. Can't access backend indexers page after creating a custom index #21510: Can't access backend indexers page after creating a custom index

Manual testing scenarios (*)

  1. Implementation of a custom index as the guide: https://devdocs.magento.com/guides/v2.2/extension-dev-guide/indexing-custom.html
  2. Login to backend
  3. Go to System > Index Management

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @ccasciotti. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@VladimirZaets VladimirZaets self-assigned this Mar 5, 2019
@magento-engcom-team
Copy link
Contributor

Hi @VladimirZaets, thank you for the review.
ENGCOM-4440 has been created to process this Pull Request

@ghost ghost assigned sidolov Mar 5, 2019
@magento-engcom-team
Copy link
Contributor

Hi @sidolov, thank you for the review.
ENGCOM-4440 has been created to process this Pull Request

@soleksii
Copy link

Hi @ccasciotti! I cannot reproduce the issue #21510 on 2.3-develop instance.
Please, re-check.
Manual testing scenario:

  1. Implementation of a custom index as the guide: https://devdocs.magento.com/guides/v2.2/extension-dev-guide/indexing-custom.html
  2. Login to backend
  3. Go to System > Index Management
    ✔️ A successful response with the list of indexers
    screen

@ccasciotti
Copy link
Contributor Author

Hi @stoleksiy,
I can confirm the issue with the above steps, I can also add that you don't have to run a reindex nor the setup:upgrade command.
The ideal scenario would be to add a new custom index to an existing module following the steps in the official guide.

@soleksii
Copy link

✔️ QA Passed

Manual testing scenario:

  1. Implementation of a custom index as the guide: https://devdocs.magento.com/guides/v2.2/extension-dev-guide/indexing-custom.html;
  2. Login to backend;
  3. Go to System > Index Management

Result:
after

@ghost
Copy link

ghost commented Mar 20, 2019

Hi @ccasciotti, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

magento-engcom-team pushed a commit that referenced this pull request Mar 20, 2019
@magento-engcom-team magento-engcom-team added this to the Release: 2.3.2 milestone Mar 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants