Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue with custom option file uploading #21170

Merged
merged 4 commits into from
Mar 8, 2019

Conversation

nikolaevas
Copy link
Contributor

@nikolaevas nikolaevas commented Feb 12, 2019

Description (*)

If sys_temp_dir and upload_tmp_dir directives in php.ini are different then it causes exception when uploading a file to product custom options on the frontend:

Path "%1" cannot be used with directory "%2"

Manual testing scenarios (*)

  1. Set different values for sys_temp_dir and upload_tmp_dir in php.ini.
  2. In magento create simple, visible in catalog product.
  3. Add new customizable option to that product with option type File.
  4. On product page on frontend select file for custom option and press Add to cart button.

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-cicd2
Copy link
Contributor

magento-cicd2 commented Feb 12, 2019

CLA assistant check
All committers have signed the CLA.

@magento-engcom-team
Copy link
Contributor

Hi @nikolaevas. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@osrecio osrecio self-assigned this Feb 15, 2019
@osrecio osrecio self-requested a review February 15, 2019 08:34
Copy link
Member

@osrecio osrecio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @nikolaevas for your contribution.

I tested in my local enviroment and works like a charm.

@magento-engcom-team
Copy link
Contributor

Hi @osrecio, thank you for the review.
ENGCOM-4275 has been created to process this Pull Request

@magento-engcom-team
Copy link
Contributor

@nikolaevas thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository.

@soleksii
Copy link

soleksii commented Mar 1, 2019

✔️ QA Passed

@nmalevanec nmalevanec self-assigned this Mar 4, 2019
@ghost ghost added the Progress: accept label Mar 5, 2019
@magento-engcom-team magento-engcom-team merged commit aeedfcd into magento:2.3-develop Mar 8, 2019
@ghost
Copy link

ghost commented Mar 8, 2019

Hi @nikolaevas, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants