Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport] Minicart-search-logo-not-vertically-aligned-2.2 #21068

Conversation

amol2jcommerce
Copy link
Contributor

Description (*)

#20905

Fixed Issues (if relevant)

  1. Minicart-search-logo-not-vertically-aligned #20955: Minicart, search & logo not vertically aligned between 640 to767 device pixel.
  2. Magento 2.2.x

Manual testing scenarios (*)

  1. Go to frontend -> resize screen (min width 640 and max width 767)

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @amol2jcommerce. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.2-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@dmytro-ch
Copy link
Contributor

dmytro-ch commented Feb 8, 2019

Hi @amol2jcommerce,
please try to avoid creating the backports until the original PR is merged.
The fixes should be delivered to mainline first.

Thank you!

@ghost
Copy link

ghost commented Mar 8, 2019

Hi @amol2jcommerce, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants