focus-not-proper-on-configurable-product-swatches:: focus not proper …

[nainesh2jcommerce]

…on configurable product swatches

Description (*)

On configurable product page, swatches not having proper focus

Manual testing scenarios (*)

1. go on configurable product
2. click on add to cart button without selecting seatch

Expected result (*)

Actual result (*)

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds on Travis CI are green)

[magento-engcom-team]

Hi @nainesh2jcommerce. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento-engcom-team give me test instance - deploy test instance based on PR changes
• @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

[dmytro-ch]

Hi @nainesh2jcommerce, thank you for your contribution!
Could you please fix the issues mentioned in the review?

[nainesh2jcommerce]

Hi @dmytro-ch, I have made changes as per review comments above, can you please review.

Thanks!

[dmytro-ch]

@magento-engcom-team give me test instance

[magento-engcom-team]

Hi @dmytro-ch. Thank you for your request. I'm working on Magento instance for you

[magento-engcom-team]

Hi @dmytro-ch, here is your new Magento instance.
Admin access: https://pr-20992.instances.magento-community.engineering/admin
Login: admin Password: 123123q

[magento-engcom-team]

Hi @dmytro-ch, thank you for the review.
ENGCOM-4145 has been created to process this Pull Request

[ghost]

Hi @nainesh2jcommerce, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.