-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed issue #20305 Update button on payment checkout is not proper alligned #20307
Fixed issue #20305 Update button on payment checkout is not proper alligned #20307
Conversation
Updated _payment.less file to fix update button issue
Hi @GovindaSharma. Thank you for your contribution
For more details, please, review the Magento Contributor Assistant documentation |
@@ -118,6 +118,7 @@ | |||
.primary { | |||
.action-update { | |||
margin-right: 0; | |||
margin-bottom:20px; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @GovindaSharma. Thanks for collaboration. Please add indent between value and property declaration.
@VladimirZaets i have fixed the indents please check and approve thanks. |
@GovindaSharma thanks! |
Hi @VladimirZaets, thank you for the review. |
Hi @GovindaSharma. Thanks for collaboration. |
@magento-engcom-team give me test instance |
Hi @GovindaSharma. Thank you for your request. I'm working on Magento instance for you |
Hi @GovindaSharma, here is your new Magento instance. |
@VladimirZaets ,thank you for your review,i have checked in test instance it is working fine.Here is the screenshot of it, As you can see update button is not too close with phone number,in the issue listed it is too close with phone no field. Actual issue screenshot is this As you can see from above screenshot ,it is too close with phone no field Please have a look once again. Thank You |
Hi @GovindaSharma. We will retest this PR and leave feedback. Thanks |
@magento-engcom-team give me test instance |
Hi @sdzhepa. Thank you for your request. I'm working on Magento instance for you |
Hi @sdzhepa, here is your new Magento instance. |
Hi @GovindaSharma, thank you for your contribution! |
…not proper alligned #20307
Description (*)
Fixed issue #20305 Update button on payment checkout is not proper alligned
Fixed Issues (if relevant)
Manual testing scenarios (*)
2.Add product to cart
3.Goto Checkout
4.On Payment Information uncheck the box of My billing and shipping address are the same
5.Go down and check update button
Contribution checklist (*)