Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed issue #20305 Update button on payment checkout is not proper alligned #20307

Merged
merged 3 commits into from
Feb 25, 2019
Merged

Fixed issue #20305 Update button on payment checkout is not proper alligned #20307

merged 3 commits into from
Feb 25, 2019

Conversation

GovindaSharma
Copy link
Contributor

Description (*)

Fixed issue #20305 Update button on payment checkout is not proper alligned

Fixed Issues (if relevant)

  1. magento/magento2 Update button on payment checkout is not proper alligned #20305: Update button on payment checkout is not proper alligned
  2. ...

Manual testing scenarios (*)

  1. Go to frontend
    2.Add product to cart
    3.Goto Checkout
    4.On Payment Information uncheck the box of My billing and shipping address are the same
    5.Go down and check update button

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

Updated _payment.less file to fix update button issue
@magento-engcom-team
Copy link
Contributor

Hi @GovindaSharma. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@@ -118,6 +118,7 @@
.primary {
.action-update {
margin-right: 0;
margin-bottom:20px;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @GovindaSharma. Thanks for collaboration. Please add indent between value and property declaration.

@GovindaSharma
Copy link
Contributor Author

@VladimirZaets i have fixed the indents please check and approve thanks.

@VladimirZaets
Copy link
Contributor

@GovindaSharma thanks!

@magento-engcom-team magento-engcom-team added this to the Release: 2.3.1 milestone Jan 17, 2019
@magento-engcom-team
Copy link
Contributor

Hi @VladimirZaets, thank you for the review.
ENGCOM-3900 has been created to process this Pull Request

@okorshenko okorshenko removed this from the Release: 2.3.1 milestone Jan 28, 2019
@VladimirZaets
Copy link
Contributor

Hi @GovindaSharma. Thanks for collaboration.
We applied your fix and issue #20305 still reproduced

@GovindaSharma
Copy link
Contributor Author

@magento-engcom-team give me test instance

@magento-engcom-team
Copy link
Contributor

Hi @GovindaSharma. Thank you for your request. I'm working on Magento instance for you

@magento-engcom-team
Copy link
Contributor

Hi @GovindaSharma, here is your new Magento instance.
Admin access: https://pr-20307.instances.magento-community.engineering/admin
Login: admin Password: 123123q

@GovindaSharma
Copy link
Contributor Author

GovindaSharma commented Jan 29, 2019

@VladimirZaets ,thank you for your review,i have checked in test instance it is working fine.Here is the screenshot of it,
screenshot-pr-20307 instances magento-community engineering-2019-01-29-11-14-45

As you can see update button is not too close with phone number,in the issue listed it is too close with phone no field.

Actual issue screenshot is this

51887173-cc4c0700-23b8-11e9-8501-eaae76f61c51

As you can see from above screenshot ,it is too close with phone no field

Please have a look once again.

Thank You

@VladimirZaets
Copy link
Contributor

Hi @GovindaSharma. We will retest this PR and leave feedback. Thanks

@sdzhepa
Copy link
Contributor

sdzhepa commented Feb 21, 2019

@magento-engcom-team give me test instance

@magento-engcom-team
Copy link
Contributor

Hi @sdzhepa. Thank you for your request. I'm working on Magento instance for you

@magento-engcom-team
Copy link
Contributor

Hi @sdzhepa, here is your new Magento instance.
Admin access: https://pr-20307.instances.magento-community.engineering/admin
Login: admin Password: 123123q

@ghost
Copy link

ghost commented Feb 25, 2019

Hi @GovindaSharma, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@magento-engcom-team magento-engcom-team merged commit 1d1bb33 into magento:2.3-develop Feb 25, 2019
magento-engcom-team pushed a commit that referenced this pull request Feb 25, 2019
@magento-engcom-team magento-engcom-team added this to the Release: 2.3.2 milestone Feb 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants