Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Issue #19891 ,Added checks of type_id #20115

Merged
merged 1 commit into from
Feb 13, 2019
Merged

Fixed Issue #19891 ,Added checks of type_id #20115

merged 1 commit into from
Feb 13, 2019

Conversation

GovindaSharma
Copy link
Contributor

Fixed Issue #19891 product_type attribute contains incorrect value in mass import export csv after creating custom type_id attribute. actual type_id value in database gets change with newly created attribute type_id.

Description (*)

Fixed Issue #19891 product_type attribute contains incorrect value in mass import export csv after creating custom type_id attribute. actual type_id value in database gets change with newly created attribute type_id.

Fixed Issues (if relevant)

  1. magento/magento2 product_type attribute contains incorrect value in mass import export csv after creating custom type_id attribute. actual type_id value in database gets change with newly created attribute type_id. #19891: product_type attribute contains incorrect value in mass import export csv after creating custom type_id attribute. actual type_id value in database gets change with newly created attribute type_id

Manual testing scenarios (*)

1.Create dropdown type product attribute with attribute code "type_id" and assign the product attribute to attribute set.

2.Create new product using that attribute and save it.

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

Fixed issue #19891 added check of attribute type_id
@magento-engcom-team
Copy link
Contributor

Hi @GovindaSharma. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@GovindaSharma
Copy link
Contributor Author

@orlangur any update on this?

@GovindaSharma
Copy link
Contributor Author

@orlangur is there any update on this? its been a long time you haven't review. please check this. it is open from last 25 days.

@magento-engcom-team
Copy link
Contributor

Hi @miguelbalparda, thank you for the review.
ENGCOM-4207 has been created to process this Pull Request

@ghost
Copy link

ghost commented Feb 13, 2019

Hi @GovindaSharma, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants