Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added custom_options file upload directory to .gitignore. #19871

Merged
merged 2 commits into from
Mar 29, 2019
Merged

Added custom_options file upload directory to .gitignore. #19871

merged 2 commits into from
Mar 29, 2019

Conversation

erfanimani
Copy link
Contributor

Solves accidentally committing an uploaded file by a developer!

@magento-cicd2
Copy link
Contributor

magento-cicd2 commented Dec 19, 2018 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@magento-engcom-team
Copy link
Contributor

Hi @erfanimani. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@VladimirZaets VladimirZaets self-assigned this Dec 19, 2018
@VladimirZaets
Copy link
Contributor

Hi @erfanimani, please, sign CLA, otherwise, we can't process your pull request

@erfanimani
Copy link
Contributor Author

Thanks, done.

@dmytro-ch dmytro-ch self-requested a review March 22, 2019 11:29
@dmytro-ch dmytro-ch self-assigned this Mar 22, 2019
@magento-engcom-team
Copy link
Contributor

Hi @dmytro-ch, thank you for the review.
ENGCOM-4558 has been created to process this Pull Request

@magento-engcom-team
Copy link
Contributor

@erfanimani thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository.

@VasylShvorak VasylShvorak self-assigned this Mar 26, 2019
@VasylShvorak
Copy link
Contributor

Notice: QA not applicable

@nmalevanec nmalevanec self-assigned this Mar 26, 2019
@magento-engcom-team magento-engcom-team merged commit 3be8eca into magento:2.3-develop Mar 29, 2019
@ghost
Copy link

ghost commented Mar 29, 2019

Hi @erfanimani, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

magento-engcom-team pushed a commit that referenced this pull request Mar 29, 2019
@sidolov
ENGCOM-4558: Added custom_options file upload directory to .gitignore. …
586b519 
…#19871
@magento-engcom-team magento-engcom-team added this to the Release: 2.3.2 milestone Mar 29, 2019
@amol2jcommerce amol2jcommerce mentioned this pull request Mar 29, 2019
Merged
@orlangur
Copy link
Contributor

orlangur commented Mar 30, 2019 •
edited
Loading

@VasylShvorak, well, it is applicable in fact.

  1. Create custom option with some media
  2. Assure working directory is still clean from Git perspective

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmytro-ch dmytro-ch dmytro-ch approved these changes

Assignees

@VladimirZaets VladimirZaets

@nmalevanec nmalevanec

@dmytro-ch dmytro-ch

@VasylShvorak VasylShvorak

Labels
Progress: accept Release Line: 2.3
Projects
None yet
Milestone
Release: 2.3.2
Development

Successfully merging this pull request may close these issues.
8 participants
@erfanimani @magento-cicd2 @magento-engcom-team @VladimirZaets @VasylShvorak @orlangur @dmytro-ch @nmalevanec