Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add EngCom Slack info to README and formatting #19696

Merged
merged 3 commits into from
Dec 12, 2018
Merged

Add EngCom Slack info to README and formatting #19696

merged 3 commits into from
Dec 12, 2018

Conversation

lorikrell
Copy link

Description (*)

No code changes
Add Community Engineering SLACK info to README
Minor formatting updates to page

Fixed Issues (if relevant)

No issue associated
EngCom request

Manual testing scenarios (*)

No testing need, no code change

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@lorikrell lorikrell requested a review from okorshenko December 10, 2018 18:02
@magento-cicd2
Copy link
Contributor

magento-cicd2 commented Dec 10, 2018

CLA assistant check
All committers have signed the CLA.

@magento-engcom-team
Copy link
Contributor

Hi @lorikrell. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

README.md Outdated Show resolved Hide resolved
@magento-engcom-team
Copy link
Contributor

Hi @okorshenko, thank you for the review.
ENGCOM-3662 has been created to process this Pull Request

@magento-engcom-team
Copy link
Contributor

Hi @lorikrell. Thank you for your contribution.
We will aim to release these changes as part of 2.3.1.
Please check the release notes for final confirmation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants