Resolve State Label Rather than Status Label #17850
Conversation
Merge 105 commits
Update my fork
Pull Request for latest files
Pull latest code
|
|
|
Hi @sskulkarni. Thank you for your contribution
For more details, please, review the Magento Contributor Assistant documentation |
|
I am changing my email address and make pull request again. |
|
I have changed Email Address. |
| @@ -55,7 +55,7 @@ public function __construct( | |||
| public function execute() | |||
| { | |||
| $itemId = (int)$this->getRequest()->getParam('item_id'); | |||
| $itemQty = (int)$this->getRequest()->getParam('item_qty'); | |||
| $itemQty = (float)$this->getRequest()->getParam('item_qty'); | |||
There was a problem hiding this comment.
This change is related with issues or PR?
There was a problem hiding this comment.
Can you revert it? To focus only in the issue. Thanks!
|
Hi @sskulkarni . You delete the entire file: UpdateItemQty.php. You only should revert the change of this commit: https://github.com/magento/magento2/pull/17850/files/020493427d1bd76fb86dc9c4be376c7871fcdd87#diff-1533c00e78677683edc94872df589b5f. When you solve it. Please squash your commits to only have one. |
| /** | ||
| * Convert State Code to State Label | ||
| */ | ||
| public function getStateLabelByCode($stateCode) |
There was a problem hiding this comment.
You cannot add public methods to classes and interfaces marked with @api. Please reimplement using the guide https://devdocs.magento.com/guides/v2.3/contributor-guide/backward-compatible-development/
There was a problem hiding this comment.
@slavvka please consider that this is not an interface, adding public methods to class shouldn't result in any negative consequences.
|
Hey @sskulkarni are you planning to complete this PR? |
|
Closed due to inactivity. Feel free to reopen if you'd like to continue progress on this PR. |
Description
We have displayed State Label rather than Status Label on Order status Grid and in a drop down in Assign Status to state.
For that I have converted State Code to State Label with some PHP function,As we don't have State Label input in Magento2.
Find screen-shots for reference.
Please consider "0204934" commit for this solution.
Fixed Issues (if relevant)
Manual testing scenarios
Contribution checklist