Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make report bugs link optional #17803

Merged
merged 2 commits into from
Oct 12, 2018
Merged

Make report bugs link optional #17803

merged 2 commits into from
Oct 12, 2018

Conversation

arnoudhgz
Copy link
Contributor

Description

Make it possible to disable report bugs link.

As developer I have removed this link a lot of times with a layout update (remove=true).

Since we most of the times do not want this by default it should be configurable whether to show this link or not.

A new setting is added under Design > Configuration > Edit > Other Settings > Footer.
The new label for this is 'Display Report Bugs Link'.

The default value for this setting is 'Yes' to keep it backwards compatible.

Manual testing scenarios

  1. Default setup with blank theme
  2. Go to frontend
  3. See 'report bugs' link in footer
  4. Go to backend > Design > Configuration > Edit > Other Settings > Footer
  5. Set setting 'Display Report Bugs Link' to 'No'
  6. Flush cache
  7. Go to frontend again
  8. See that 'report bugs' link is removed from footer

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@arnoudhgz
Merge remote-tracking branch 'upstream/2.3-develop' into 2.3-develop
8bc1c6f
@arnoudhgz
Make it possible to disable report bugs link
9fe66f7 
As developer I have removed this link a lot of times with a layout
update (remove=true).

Since we most of the times do not want this by default it should be
configurable whether to show this link or not.

A new setting is added under Design > Configuration > Edit > Other
Settings > Footer. The new label is 'Display Report Bugs Link'.

The default value for this setting is 'Yes' to keep it backwards
compatible.
@magento-engcom-team magento-engcom-team added Partner: MediaCT Pull Request is created by partner MediaCT partners-contribution Pull Request is created by Magento Partner Area: Frontend Component: Theme labels Aug 26, 2018
@magento-engcom-team
Copy link
Contributor

Hi @arnoudhgz. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me {$VERSION} instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@miguelbalparda miguelbalparda self-assigned this Aug 28, 2018
@ishakhsuvarov ishakhsuvarov added this to the Release: 2.3.1 milestone Sep 18, 2018
@arnoudhgz
Copy link
Contributor Author

@miguelbalparda any news on your review?

@miguelbalparda
Copy link
Contributor

Yes, this is not going to be included in the next release. I'll report back once 2.3 is out and we can continue working towards 2.3.1. Thanks!

@slavvka slavvka self-assigned this Oct 4, 2018
@magento-engcom-team
Copy link
Contributor

Hi @slavvka, thank you for the review.
ENGCOM-3098 has been created to process this Pull Request

@magento-engcom-team magento-engcom-team merged commit 9fe66f7 into magento:2.3-develop Oct 12, 2018
magento-engcom-team pushed a commit that referenced this pull request Oct 12, 2018
ENGCOM-3098: Make report bugs link optional #17803
6444c28
@magento-engcom-team
Copy link
Contributor

Hi @arnoudhgz. Thank you for your contribution.
We will aim to release these changes as part of 2.3.1.
Please check the release notes for final confirmation.

@slavvka
Copy link
Member

slavvka commented Oct 12, 2018

Please, consider to port this solution to 2.2 release line if applicable
You may use Porting tool (https://devdocs.magento.com/guides/v2.2/contributor-guide/contributing.html#porting-tool) to port commits automatically.

@gelanivishal gelanivishal mentioned this pull request Oct 12, 2018
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slavvka slavvka slavvka approved these changes

Assignees

@miguelbalparda miguelbalparda

@slavvka slavvka

Labels
Area: Frontend Component: Theme Partner: MediaCT Pull Request is created by partner MediaCT partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.3
Projects
None yet
Milestone
Release: 2.3.1
Development

Successfully merging this pull request may close these issues.
5 participants
@arnoudhgz @magento-engcom-team @miguelbalparda @slavvka @ishakhsuvarov