Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Forwardport] Add sort order to user agent rules table headers #16792

Merged

Conversation

JRhyne
Copy link

@JRhyne JRhyne commented Jul 13, 2018

Original Pull Request

#16704

Summary / Description

Only one column on the User Agent Rules table had a sort order. This was causing the content of the table rows to not match the content of the table. I added the sortOrder attribute on the other two columns and this fixed the issue.

Fixed Issues (if relevant)

  1. User Agent Rules table headers do match content of rows. #16703 : User Agent Rules table headers do match content of rows

Manual testing scenarios

  1. Visit the page where you can edit a design configuration (change the theme). And review the table's headers.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • [] All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @JRhyne. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me {$VERSION} instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@magento-engcom-team
Copy link
Contributor

Hi @JRhyne. Thank you for your contribution.
We will aim to release these changes as part of 2.3.0.
Please check the release notes for final confirmation.

@JRhyne JRhyne deleted the 2.3-develop-PR-port-16704 branch July 25, 2018 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants