Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Forwardport] [Resolved : Styling <select> by changing less variables in Luma theme… #15794

Conversation

hitesh-wagento
Copy link
Contributor

Original Pull Request

#15734
Have "select" elements with the styles you set in _theme.less

Description

Fixed Issues (if relevant)

  1. magento/magento2#Styling <select> by changing less variables in Luma theme doesn't work as expected #15608 : Issue title Styling select by changing less variables in Luma theme doesn't work as expected

Manual testing scenarios

  1. In Custom/theme/web/css/source/_theme.less set less variables:
    @select__background: rgba(255, 255, 255, 0.15);
    @select__border: 2px dashed blue;
    @select__height: 50px;
    @select__padding: 15px 40px 15px 15px;
    @select__background-clip: border-box;
  2. Compile less

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @hitesh-wagento. Thank you for your contribution.
Changes from your Pull Request will be available with the upcoming 2.3.0 release.

@hitesh-wagento hitesh-wagento deleted the 2.3-develop-PR-port-15734 branch September 6, 2018 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Lib/Frontend Partner: Wagento Pull Request is created by partner Wagento partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.3
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants